Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754047AbcLKXbg (ORCPT ); Sun, 11 Dec 2016 18:31:36 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35042 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753930AbcLKXbe (ORCPT ); Sun, 11 Dec 2016 18:31:34 -0500 Date: Sun, 11 Dec 2016 15:31:31 -0800 From: Eric Biggers To: Andy Lutomirski Cc: linux-crypto@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "kernel-hardening@lists.openwall.com" , Herbert Xu , Andrew Lutomirski , Stephan Mueller Subject: Re: Remaining crypto API regressions with CONFIG_VMAP_STACK Message-ID: <20161211233131.GA1210@zzz> References: <20161209230851.GB64048@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1188 Lines: 41 On Sun, Dec 11, 2016 at 11:13:55AM -0800, Andy Lutomirski wrote: > On Fri, Dec 9, 2016 at 3:08 PM, Eric Biggers wrote: > > In the 4.9 kernel, virtually-mapped stacks will be supported and enabled by > > default on x86_64. This has been exposing a number of problems in which > > on-stack buffers are being passed into the crypto API, which to support crypto > > accelerators operates on 'struct page' rather than on virtual memory. > > > > > fs/cifs/smbencrypt.c:96 > > This should use crypto_cipher_encrypt_one(), I think. > > --Andy Yes, I believe that's correct. It encrypts 8 bytes with ecb(des) which is equivalent to simply encrypting one block with DES. Maybe try the following (untested): static int smbhash(unsigned char *out, const unsigned char *in, unsigned char *key) { unsigned char key2[8]; struct crypto_cipher *cipher; str_to_key(key, key2); cipher = crypto_alloc_cipher("des", 0, 0); if (IS_ERR(cipher)) { cifs_dbg(VFS, "could not allocate des cipher\n"); return PTR_ERR(cipher); } crypto_cipher_setkey(cipher, key2, 8); crypto_cipher_encrypt_one(cipher, out, in); crypto_free_cipher(cipher); return 0; } - Eric