Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754087AbcLLEAL (ORCPT ); Sun, 11 Dec 2016 23:00:11 -0500 Received: from mail-oi0-f47.google.com ([209.85.218.47]:35453 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638AbcLLEAI (ORCPT ); Sun, 11 Dec 2016 23:00:08 -0500 MIME-Version: 1.0 In-Reply-To: <20161209213629.76ixdmr24ln72uaw@rob-hp-laptop> References: <1480855321-5047-1-git-send-email-tqnguyen@apm.com> <20161209213629.76ixdmr24ln72uaw@rob-hp-laptop> From: "Thang Q. Nguyen" Date: Mon, 12 Dec 2016 11:00:07 +0700 Message-ID: Subject: Re: usb:xhci: support disable usb2 LPM Remote Wakeup To: Rob Herring Cc: Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Mathias Nyman , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Phong Vo , Loc Ho , Vu Nguyen , patches Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1840 Lines: 47 On Sat, Dec 10, 2016 at 4:36 AM, Rob Herring wrote: > On Sun, Dec 04, 2016 at 07:42:01PM +0700, Thang Q. Nguyen wrote: >> From: Thang Nguyen >> >> As per USB 2.0 link power management addendum ECN, table 1-2, page 4, >> device or host initiated via resume signaling; device-initiated resumes >> can be optionally enabled/disabled by software. This patch adds support >> to control enabling the USB2 RWE feature via DT/ACPI attribute. >> >> Signed-off-by: Vu Nguyen >> Signed-off-by: Thang Nguyen >> --- >> Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + >> drivers/usb/host/xhci-plat.c | 3 +++ >> drivers/usb/host/xhci.c | 5 ++++- >> drivers/usb/host/xhci.h | 1 + >> 4 files changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt >> index 966885c..9b4cd14 100644 >> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt >> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt >> @@ -25,6 +25,7 @@ Required properties: >> >> Optional properties: >> - clocks: reference to a clock >> + - usb2-rwe-disable: disable USB2 LPM Remote Wakeup capable > > Remote wakeup has been around since USB 1.0 days. Does this need to be > USB2 or XHCI specific? This is XHCI specific. Per XHCI specification 1.1, remote wakeup is optional for XHCI 1.0 and required for XHCI 1.1. This patch provides ability for software to disable RWE for USB2 in XHCI1.0 controller. > >> - usb3-lpm-capable: determines if platform is USB3 LPM capable >> >> Example: -- Thang Q. Nguyen | Staff SW Eng. C: +849.7684.7606 | O: +848.3770.0640 F: +848.3770.0641 | tqnguyen@apm.com