Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753590AbcLLIM3 (ORCPT ); Mon, 12 Dec 2016 03:12:29 -0500 Received: from s3.sipsolutions.net ([5.9.151.49]:37198 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbcLLIM1 (ORCPT ); Mon, 12 Dec 2016 03:12:27 -0500 Message-ID: <1481530339.4067.1.camel@sipsolutions.net> Subject: Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN? From: Johannes Berg To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Ming Lei , "Luis R. Rodriguez" , Linux Kernel Mailing List Cc: "linux-wireless@vger.kernel.org" , brcm80211 development Date: Mon, 12 Dec 2016 09:12:19 +0100 In-Reply-To: (sfid-20161210_165513_587245_23610C6B) References: (sfid-20161210_165513_587245_23610C6B) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 19 On Sat, 2016-12-10 at 16:54 +0100, Rafał Miłecki wrote: > Hi, > > In brcmfmac we use request_firmware_nowait and if fetching firmware > with NVRAM variables fails then we try to fallback to the platform > one (see brcmf_fw_request_code_done & brcmf_fw_request_nvram_done). > > Some problem for us is that on devices with platform NVRAM we get > this error: > Direct firmware load for brcm/brcmfmac43602-pcie.txt failed with error -2 This also happens with iwlwifi, because it requests multiple firmware versions starting at the most recent supported one (which is often not released at the same time). So yeah, this would be really useful - why don't you just make a patch with some kind of flags, whether it's FW_OPT_* or new flags? johannes