Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753346AbcLLIc3 (ORCPT ); Mon, 12 Dec 2016 03:32:29 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34640 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbcLLIc1 (ORCPT ); Mon, 12 Dec 2016 03:32:27 -0500 MIME-Version: 1.0 In-Reply-To: <1481530339.4067.1.camel@sipsolutions.net> References: <1481530339.4067.1.camel@sipsolutions.net> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Mon, 12 Dec 2016 09:32:26 +0100 Message-ID: Subject: Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN? To: Johannes Berg Cc: Ming Lei , "Luis R. Rodriguez" , Linux Kernel Mailing List , "linux-wireless@vger.kernel.org" , brcm80211 development Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBC8WY5r018176 Content-Length: 1130 Lines: 29 On 12 December 2016 at 09:12, Johannes Berg wrote: > On Sat, 2016-12-10 at 16:54 +0100, Rafał Miłecki wrote: >> In brcmfmac we use request_firmware_nowait and if fetching firmware >> with NVRAM variables fails then we try to fallback to the platform >> one (see brcmf_fw_request_code_done & brcmf_fw_request_nvram_done). >> >> Some problem for us is that on devices with platform NVRAM we get >> this error: >> Direct firmware load for brcm/brcmfmac43602-pcie.txt failed with error -2 > > This also happens with iwlwifi, because it requests multiple firmware > versions starting at the most recent supported one (which is often not > released at the same time). Good to know it may help others as well! > So yeah, this would be really useful - why don't you just make a patch > with some kind of flags, whether it's FW_OPT_* or new flags? OK! If noone will come with any special comments/ideas soon, I'll propose a patch for using some flags. FWIW, meanwhile I submitted [PATCH V2] firmware: simplify defining and handling FW_OPT_FALLBACK https://patchwork.kernel.org/patch/9469875/ -- Rafał