Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753978AbcLLIow (ORCPT ); Mon, 12 Dec 2016 03:44:52 -0500 Received: from mga01.intel.com ([192.55.52.88]:63440 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750712AbcLLIou (ORCPT ); Mon, 12 Dec 2016 03:44:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,334,1477983600"; d="asc'?scan'208";a="1080643424" From: Felipe Balbi To: Bjorn Helgaas , Mathias Nyman Cc: Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Should xhci_irq() call usb_hc_died()? In-Reply-To: <20161210002616.GA8381@bhelgaas-glaptop.roam.corp.google.com> References: <20161210002616.GA8381@bhelgaas-glaptop.roam.corp.google.com> Date: Mon, 12 Dec 2016 10:43:31 +0200 Message-ID: <87fultill8.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1831 Lines: 61 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Bjorn Helgaas writes: > Hi Mathias, > > ehci_irq(), ohci_irq(), fotg210_irq(), and oxu210_hcd_irq() contain code > equivalent to this: > > status =3D ehci_readl(...); > if (status =3D=3D ~(u32) 0) { > ... > usb_hc_died(hcd); > ... > return IRQ_HANDLED; > } > > xhci_irq() has a similar check, but does not call usb_hc_died(): > > status =3D readl(...); > if (status =3D 0xffffffff) { > ... > return IRQ_HANDLED; > } > > Should xhci_irq() also call usb_hc_died()? Maybe there's some reason > for it to be different than the others, but it wasn't obvious to this > casual observer :) you might just have fixed several bugs in dealing with a dead HC :-) Can you provide a patch? (well, unless Mathias has a strong reason not to call usb_hc_died(), of course). =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlhOYzMACgkQzL64meEa mQYbJg//ZZhNNmoT+SDqJK9MQrSz2P92KOqWn9LINT0+wpot4kDk18+NcRPR/MBb bt+fSEWOAaNCbZ8Xzv15wKfO3iTfycgMoBhCr/pRiofRP0zBc7o0l52Kg86E8iO0 pnQ4banYHPyI806JgZW8HUyiHhM1qVXl+3Loyakj0z4dX9Vh4B5Vjiv9DlJ+feRr 2oAUMec3je9GywQEv0bLNJR5aWMFaPJdHysvTomNwJ8ONxW13Tvj8bTSeM2i7xeb Q6tEUIbUSMHWqbmu2e1IsZ5ztewFSuPZe3fB84rd5qzxBpL+NF+xtm/nJgXDRtPH LYKYKn7Co4/hqpPdFLPxEIt4PDeQARQ8s/HzsWwqlpBQFqvGWloDSsw7letTzu3o nxZGDyzb8G4EOcViAVC+Xh/tCCeMKK9fY00wGKZayB4DUOWMZlz20lmK6VPfzLoP T+3KzqQoTXLmepuUJj1tSxoBRumsl+xiT8/J2eVsIt1HpA7Dl91G0eHqe0hMO+wO /z5JgAhZleKZ7HIwqz1jzrkl8PIqaMZXu6Eob/szolFgGjsFomM7VDQHCePXyTxo vaeaUL4kLK6EcG+LOWT1hAKhgf9Wrr3ROgFOOTNBUC0zITd9WjH8zZUN8mjtt/7s OSGsFmaD1c3NUC6DvnVEcfifRVK6RjhI8FGJkUjRXt0nj+5pnrI= =YoZx -----END PGP SIGNATURE----- --=-=-=--