Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932333AbcLLJxq (ORCPT ); Mon, 12 Dec 2016 04:53:46 -0500 Received: from mail-oi0-f52.google.com ([209.85.218.52]:34351 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbcLLJxo (ORCPT ); Mon, 12 Dec 2016 04:53:44 -0500 MIME-Version: 1.0 In-Reply-To: <815a15b6-f22d-8c45-f76c-2c756f159366@broadcom.com> References: <1481530339.4067.1.camel@sipsolutions.net> <815a15b6-f22d-8c45-f76c-2c756f159366@broadcom.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Mon, 12 Dec 2016 10:53:38 +0100 Message-ID: Subject: Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN? To: Arend Van Spriel Cc: Johannes Berg , Ming Lei , "Luis R. Rodriguez" , Linux Kernel Mailing List , "linux-wireless@vger.kernel.org" , brcm80211 development Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBC9rr2c019101 Content-Length: 1782 Lines: 44 On 12 December 2016 at 10:26, Arend Van Spriel wrote: > On 12-12-2016 9:32, Rafał Miłecki wrote: >> On 12 December 2016 at 09:12, Johannes Berg wrote: >>> On Sat, 2016-12-10 at 16:54 +0100, Rafał Miłecki wrote: >>>> In brcmfmac we use request_firmware_nowait and if fetching firmware >>>> with NVRAM variables fails then we try to fallback to the platform >>>> one (see brcmf_fw_request_code_done & brcmf_fw_request_nvram_done). >>>> >>>> Some problem for us is that on devices with platform NVRAM we get >>>> this error: >>>> Direct firmware load for brcm/brcmfmac43602-pcie.txt failed with error -2 >>> >>> This also happens with iwlwifi, because it requests multiple firmware >>> versions starting at the most recent supported one (which is often not >>> released at the same time). >> >> Good to know it may help others as well! >> >> >>> So yeah, this would be really useful - why don't you just make a patch >>> with some kind of flags, whether it's FW_OPT_* or new flags? >> >> OK! If noone will come with any special comments/ideas soon, I'll >> propose a patch for using some flags. >> >> FWIW, meanwhile I submitted >> [PATCH V2] firmware: simplify defining and handling FW_OPT_FALLBACK >> https://patchwork.kernel.org/patch/9469875/ > > Similar thread couple of months ago [1] > > (...) > > [1] http://lists.infradead.org/pipermail/ath10k/2016-July/thread.html#8026 Oh, now I see it's a bit messy topic and not clearly maintained class. It seems more ppl were confused by the API. I think having many unrelated behavior bounded to few functions caused some of this confusion. Let's hope adding some flags will let us use function the way they were designed, I'll definitely try working on this. -- Rafał