Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932610AbcLLKsF (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Dec 2016 05:48:05 -0500
Received: from regular1.263xmail.com ([211.150.99.134]:47253 "EHLO
        regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932196AbcLLKsC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Dec 2016 05:48:02 -0500
X-263anti-spam: KSV:0;
X-MAIL-GRAY: 0
X-MAIL-DELIVERY: 1
X-KSVirus-check: 0
X-ABS-CHECKED: 4
X-RL-SENDER: wxt@rock-chips.com
X-FST-TO: wxt@rock-chips.com
X-SENDER-IP: 47.89.33.70
X-LOGIN-NAME: wxt@rock-chips.com
X-UNIQUE-TAG: <d630eed9772dfd9338311a971b2b5af3>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Subject: Re: [PATCH v3 1/5] thermal: rockchip: improve conversion error
 messages
To: Eduardo Valentin <edubezval@gmail.com>,
        Brian Norris <briannorris@chromium.org>
References: <1480331524-18741-1-git-send-email-wxt@rock-chips.com>
 <1480331524-18741-2-git-send-email-wxt@rock-chips.com>
 <20161129015155.GA3329@localhost.localdomain>
 <20161129054728.GA64845@google.com>
 <20161130050420.GB27079@localhost.localdomain>
Cc: heiko@sntech.de, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, smbarber@chromium.org,
        linux-rockchip@lists.infradead.org, rui.zhang@intel.com,
        Caesar Wang <wxt@rock-chips.com>
From: Caesar Wang <wxt@rock-chips.com>
Message-ID: <84cc3087-8c81-4054-c941-949a12966d32@rock-chips.com>
Date: Mon, 12 Dec 2016 18:47:30 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20161130050420.GB27079@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 889
Lines: 32

在 2016年11月30日 13:04, Eduardo Valentin 写道:
> Hey,
>
> On Mon, Nov 28, 2016 at 09:47:29PM -0800, Brian Norris wrote:
>> Hi,
>>
> <cut>
>
>>>> +		       __func__, table.mode);
>>> Given that we are improving messages, would it be more informative to
>>> say that you have an invalid table mode?
>> I considered the mode and ID listing to go hand in hand, so it was the
>> whole table that is wrong. But it is just as well to say the "table
>> mode" is wrong.
>>
>> Maybe even better: "%s: unknown table mode: %d\n".
>>
> Yup, that works for me, even better.

Done.  Sorry for delay.

>> And I guess same answer for patch 4, where you had the same question.
> yes
>
>> Brian
>>
>>>> +		return -EINVAL;
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip