Subject: Re: [PATCH 1/1] Fixed checkpatch error to mmu.c
To: Ozgur Karatas <okaratas@member.fsf.org>, christoffer.dall@linaro.org,
        pbonzini@redhat.com
References: <962731481539605@web19g.yandex.ru>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        kvm@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <2f7d41cd-bf48-129d-aa91-d464fd6ce671@arm.com>
Date: Mon, 12 Dec 2016 11:02:15 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.2.0
MIME-Version: 1.0
In-Reply-To: <962731481539605@web19g.yandex.ru>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1157
Lines: 35

Hi Ozgur,

On 12/12/16 10:46, Ozgur Karatas wrote:
> Hello all,
> 
> I tested to mmu.c and I have fixed to some errors.
> 
> mmu.c:510: ERROR: "(foo*)" should be "(foo *)"
> 
> Signed-off-by: Ozgur Karatas <okaratas@member.fsf.org>
> ---
> arch/arm/kvm/mmu.c                       |  2 +-
> 
> diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
> index a5265ed..a83cf47 100644
> --- a/arch/arm/kvm/mmu.c
> +++ b/arch/arm/kvm/mmu.c
> @@ -507,7 +507,7 @@ void free_hyp_pgds(void)
>  		unmap_hyp_range(hyp_pgd, hyp_idmap_start, PAGE_SIZE);
>  		for (addr = PAGE_OFFSET; virt_addr_valid(addr); addr += PGDIR_SIZE)
>  			unmap_hyp_range(hyp_pgd, kern_hyp_va(addr), PGDIR_SIZE);
> -		for (addr = VMALLOC_START; is_vmalloc_addr((void*)addr); addr += PGDIR_SIZE)
> +		for (addr = VMALLOC_START; is_vmalloc_addr((void *)addr); addr += PGDIR_SIZE)
>  			unmap_hyp_range(hyp_pgd, kern_hyp_va(addr), PGDIR_SIZE);
> 

I'm not overly sympathetic to pure checkpatch patches. If you find
something that is a functional bug in that file, I'll consider it as
part of a series. But on its own, this is just noise.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...