Date: Mon, 12 Dec 2016 14:27:47 +0300
From: Roman Kagan <rkagan@virtuozzo.com>
To: Paolo Bonzini <pbonzini@redhat.com>
CC: <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
        <dvyukov@google.com>
Subject: Re: [PATCH v2] KVM: hyperv: fix locking of struct kvm_hv fields
Message-ID: <20161212112747.GA2087@rkaganb.sw.ru>
Mail-Followup-To: Roman Kagan <rkagan@virtuozzo.com>,
        Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, dvyukov@google.com
References: <20161212091253.19780-1-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20161212091253.19780-1-pbonzini@redhat.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
SpamDiagnosticOutput: 1:22
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2016 11:27:53.1439 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2469
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 702
Lines: 16

On Mon, Dec 12, 2016 at 10:12:53AM +0100, Paolo Bonzini wrote:
> Introduce a new mutex to avoid an AB-BA deadlock between kvm->lock and
> vcpu->mutex.  Protect accesses in kvm_hv_setup_tsc_page too, as suggested
> by Roman.
> 
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Cc: Roman Kagan <rkagan@virtuozzo.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Documentation/virtual/kvm/locking.txt |  8 ++++++--
>  arch/x86/include/asm/kvm_host.h       |  1 +
>  arch/x86/kvm/hyperv.c                 | 24 +++++++++++++++---------
>  arch/x86/kvm/x86.c                    |  1 +
>  4 files changed, 23 insertions(+), 11 deletions(-)

Reviewed-by: Roman Kagan <rkagan@virtuozzo.com>