Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753892AbcLLRns (ORCPT ); Mon, 12 Dec 2016 12:43:48 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36354 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752965AbcLLRnp (ORCPT ); Mon, 12 Dec 2016 12:43:45 -0500 From: Arvind Yadav To: tj@kernel.org Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [V1] ata: sata_mv:- Handle return value of devm_ioremap. Date: Mon, 12 Dec 2016 23:13:27 +0530 Message-Id: <1481564607-9626-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 26 Here, If devm_ioremap will fail. It will return NULL. Then hpriv->base = NULL - 0x20000; Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. Signed-off-by: Arvind Yadav --- drivers/ata/sata_mv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index efc48bf..9d0cdad 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -4119,6 +4119,9 @@ static int mv_platform_probe(struct platform_device *pdev) host->iomap = NULL; hpriv->base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); + if (!hpriv->base) + return -ENOMEM; + hpriv->base -= SATAHC0_REG_BASE; hpriv->clk = clk_get(&pdev->dev, NULL); -- 2.7.4