Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753692AbcLLR7m (ORCPT ); Mon, 12 Dec 2016 12:59:42 -0500 Received: from mga06.intel.com ([134.134.136.31]:62489 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbcLLR7l (ORCPT ); Mon, 12 Dec 2016 12:59:41 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,337,1477983600"; d="scan'208";a="1098136861" Date: Mon, 12 Dec 2016 19:59:31 +0200 From: Jarkko Sakkinen To: "Winkler, Tomas" Cc: Peter Huewe , open list , "linux-security-module@vger.kernel.org" , "moderated list:TPM DEVICE DRIVER" Subject: Re: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers Message-ID: <20161212175931.6psvcj52lmwovcit@intel.com> References: <20161207115001.18332-1-jarkko.sakkinen@linux.intel.com> <20161207115001.18332-2-jarkko.sakkinen@linux.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B5433A4BD@hasmsx108.ger.corp.intel.com> <20161212152001.53ewps3jczs4jdld@intel.com> <20161212153108.mc5xf72npprz7wpe@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B5433B553@hasmsx108.ger.corp.intel.com> <20161212175306.6lnuh5cj7bhqxdov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161212175306.6lnuh5cj7bhqxdov@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2349 Lines: 67 On Mon, Dec 12, 2016 at 07:53:06PM +0200, Jarkko Sakkinen wrote: > On Mon, Dec 12, 2016 at 03:57:54PM +0000, Winkler, Tomas wrote: > > > > On Mon, Dec 12, 2016 at 02:25:32PM +0000, Winkler, Tomas wrote: > > > > > > > > > > > > In order to provide access to locality registers, this commits > > > > > > adds mapping of the head of the CRB registers, which are located right > > > before the control area. > > > > > > > > > > > > Signed-off-by: Jarkko Sakkinen > > > > > > --- > > > > > > drivers/char/tpm/tpm_crb.c | 89 > > > > > > +++++++++++++++++++++++++++++------------ > > > > > > ----- > > > > > > 1 file changed, 57 insertions(+), 32 deletions(-) > > > > > > > > > > > > diff --git a/drivers/char/tpm/tpm_crb.c > > > > > > b/drivers/char/tpm/tpm_crb.c index > > > > > > 717b6b4..80b9759 100644 > > > > > > --- a/drivers/char/tpm/tpm_crb.c > > > > > > +++ b/drivers/char/tpm/tpm_crb.c > > > > > > @@ -52,18 +52,28 @@ enum crb_cancel { > > > > > > CRB_CANCEL_INVOKE = BIT(0), > > > > > > }; > > > > > > > > > > > > -struct crb_control_area { > > > > > > - u32 req; > > > > > > - u32 sts; > > > > > > - u32 cancel; > > > > > > - u32 start; > > > > > > - u32 int_enable; > > > > > > - u32 int_sts; > > > > > > - u32 cmd_size; > > > > > > - u32 cmd_pa_low; > > > > > > - u32 cmd_pa_high; > > > > > > - u32 rsp_size; > > > > > > - u64 rsp_pa; > > > > > > +struct crb_regs_head { > > > > > > + u32 loc_state; > > > > > > + u32 reserved1; > > > > > > + u32 loc_ctrl; > > > > > > + u32 loc_sts; > > > > > > + u8 reserved2[32]; > > > > > > + u64 intf_id; > > > > > > + u64 ctrl_ext; > > > > > > +} __packed; > > > > > > + > > > > > > > > > > > +struct crb_regs_tail { > > > > > Why to change the name this is still control_area > > > > > > And how would you name struct crb_regs_h then? > > > > Just crb_regs > > > > > In my opinion PC it makes a lot of sense to speak about registers here rather > > > than control area now that it is extended to the full range. The PC Client > > > Specification also speaks about registers. > > > > Right so crb_regs is to be and the nonstandard implementation of the > > legacy platforms should be even factored out. > > I do not see that we would stop supporting pre-Skylake platforms in the > near future so probably won't be factored out. s/near/forseeable/ /Jarkko