MIME-Version: 1.0
In-Reply-To: <a09b8dbc-ca4b-000e-e5c2-5039119e99ba@gmail.com>
References: <1481479310-2698-1-git-send-email-arvind.yadav.cs@gmail.com> <a09b8dbc-ca4b-000e-e5c2-5039119e99ba@gmail.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Mon, 12 Dec 2016 16:19:24 -0200
Message-ID: <CAOMZO5DsH_4oLOjWjuJH0Z_OD-TYU42b9MkGh7AJ6N=ODt=DTw@mail.gmail.com>
Subject: Re: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap.
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
        Robert Jarzmik <robert.jarzmik@free.fr>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Richard Weinberger <richard@nod.at>,
        Cyrille Pitchen <cyrille.pitchen@atmel.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 438
Lines: 12

On Sun, Dec 11, 2016 at 5:15 PM, Marek Vasut <marek.vasut@gmail.com> wrote:

>>       ret = -ENOMEM;
>> +     base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE);
>> +     if (!base)
>> +             return ret;
>
> I think return -ENOMEM right away won't hurt here. Also, dev_err()
> explaining the failure would be nice to add.

There is no need to add dev_err() message as the mm core will complain
loudly if devm_ioremap() fails.