Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752938AbcLLSj1 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Dec 2016 13:39:27 -0500
Received: from smtprelay0223.hostedemail.com ([216.40.44.223]:39485 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752495AbcLLSjZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Dec 2016 13:39:25 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:10004:10400:10848:11026:11232:11473:11657:11658:11783:11889:11914:12043:12438:12740:13069:13161:13229:13311:13357:13439:13894:14181:14659:14721:21080:21433:21451:30045:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: spy82_8b3f36b8e2153
X-Filterd-Recvd-Size: 2114
Message-ID: <1481567955.1764.28.camel@perches.com>
Subject: Re: [PATCH] ACPI: small formatting fixes
From: Joe Perches <joe@perches.com>
To: Nick Desaulniers <nick.desaulniers@gmail.com>,
        Pavel Machek <pavel@ucw.cz>
Cc: rjw@rjwysocki.net, len.brown@intel.com, tglx@linutronix.de,
        mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 12 Dec 2016 10:39:15 -0800
In-Reply-To: <20161212175654.ydc7rx3edqoacnp7@lostoracle.net>
References: <20161212072541.28435-1-nick.desaulniers@gmail.com>
         <20161212085620.GA738@amd> <20161212175654.ydc7rx3edqoacnp7@lostoracle.net>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.1-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1113
Lines: 33

On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote:
> A quick cleanup that passes scripts/checkpatch.pl -f <file>.

You might use the --strict option for acpi files.

> diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
[]
> @@ -103,9 +103,8 @@ static long acpi_processor_ffh_cstate_probe_cpu(void *_cx)
> ?
> ????????if (!mwait_supported[cstate_type]) {
> ????????????????mwait_supported[cstate_type] = 1;
> -???????????????printk(KERN_DEBUG
> -???????????????????????"Monitor-Mwait will be used to enter C-%d "
> -???????????????????????"state\n", cx->type);
> +???????????????pr_debug("Monitor-Mwait will be used to enter C-%d state\n",
> +???????????????????????????????cx->type);

It's generally better not to convert
these printk(KERN_DEBUG uses.

There are behavior differences between
	printk(KERN_DEBUG ...);
and
	pr_debug(...);

The first will always be emitted as long
as the console level is appropriate.

The second depends on a #define DEBUG
before it gets emitted or a kernel
with CONFIG_DYNAMIC_DEBUG enabled and
this entry specifically enabled in the
control file.