Date: Mon, 12 Dec 2016 11:04:04 -0800
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Imran Khan <kimran@codeaurora.org>
Cc: andy.gross@linaro.org, lee.jones@linaro.org,
        David Brown <david.brown@linaro.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>
Subject: Re: [PATCH v5] soc: qcom: Add SoC info driver
Message-ID: <20161212190404.GA3439@tuxbot>
References: <1479302540-16690-1-git-send-email-kimran@codeaurora.org>
 <20161205180503.GK9322@tuxbot>
 <70a5a48a-4b6c-f564-99e4-758a9c5d598a@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <70a5a48a-4b6c-f564-99e4-758a9c5d598a@codeaurora.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1043
Lines: 30

On Mon 12 Dec 07:14 PST 2016, Imran Khan wrote:

> On 12/5/2016 11:35 PM, Bjorn Andersson wrote:
[..]
> > 
> > Rather than having this based on two huge macros take a look at
> > DEVICE_INT_ATTR() and struct dev_ext_attribute in
> > include/linux/device.h. It looks like if you just put the index in a
> > struct and use container_of to reach that you can replace these with
> > direct functions.
> > 
> > Also, it's perfectly fine to always specify a store operation and use
> > 0444 vs 0644 to control it's availability. So you don't need two sets if
> > you just expose the mode in your macro.
> >
> 
> If I understood this correct, the main idea here is to use dev_ext_attribute
> and avoid wrapper macros. Have tried to implement this suggestion in the 
> subsequent patch set. Please let me know if it looks okay or can be improved
> further. 
>  

Not necessarily using dev_ext_attribute directly, but using the same
design (a struct and container_of) allows you do parameterize these
functions.

Looking forward to v6.

Regards,
Bjorn