Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753021AbcLLUAH (ORCPT ); Mon, 12 Dec 2016 15:00:07 -0500 Received: from casper.infradead.org ([85.118.1.10]:50910 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750712AbcLLUAG (ORCPT ); Mon, 12 Dec 2016 15:00:06 -0500 Date: Mon, 12 Dec 2016 20:00:02 +0000 (GMT) From: James Simmons To: Greg Kroah-Hartman cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , James Simmons , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h In-Reply-To: <20161210181649.GB8477@kroah.com> Message-ID: References: <1481393161-22623-1-git-send-email-jsimmons@infradead.org> <1481393161-22623-6-git-send-email-jsimmons@infradead.org> <20161210181649.GB8477@kroah.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161212_200002_183910_B2835D38 X-CRM114-Status: GOOD ( 14.21 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1033 Lines: 21 > On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > > In order for lustre_idl.h to be usable for both user > > land and kernel space it has to use the proper > > byteorder functions. > > Why would userspace need/want all of these inline functions? A uapi > header file should just have a the structures that are passed > user/kernel and any needed ioctls. Why would they ever care about > strange byte flip functions and a ton of inline functions? > > I don't think this is needed, of if it is, I really don't want to see > your crazy userspace code... Sigh. More cleanups were done based on the idea this was okay. The reason this was does was when you look at the headers in include/uapi/linux you see a huge number of headers containing a bunch of inline function. To an outside project looking to merge their work into the kernel they would think this is okay. Hopefully all those broken headers will be cleaned up in the near future. Alright I will look to fixing up our tools to handle this requirement.