Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753442AbcLLVB2 (ORCPT ); Mon, 12 Dec 2016 16:01:28 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35341 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753390AbcLLVB0 (ORCPT ); Mon, 12 Dec 2016 16:01:26 -0500 Date: Tue, 13 Dec 2016 00:01:18 +0300 From: "Kirill A. Shutemov" To: "Aneesh Kumar K.V" Cc: akpm@linux-foundation.org, "Kirill A . Shutemov" , mpe@ellerman.id.au, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/thp/pagecache: Only withdraw page table after a successful deposit Message-ID: <20161212210118.GB10202@node.shutemov.name> References: <20161212163428.6780-1-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161212163428.6780-1-aneesh.kumar@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 652 Lines: 16 On Mon, Dec 12, 2016 at 10:04:27PM +0530, Aneesh Kumar K.V wrote: > The current code wrongly called withdraw in the error path. But we > haven't depoisted the page table yet in the only error path in that > function. So for now remove that withdraw completely. If we take > that "out:" branch, we should have vmf->prealloc_pte already pointing > to the allocated page table. > > Fixes: "mm: THP page cache support for ppc64" > > Signed-off-by: Aneesh Kumar K.V Reported-by: Kirill A. Shutemov Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov