Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753259AbcLLVR4 (ORCPT ); Mon, 12 Dec 2016 16:17:56 -0500 Received: from sandeen.net ([63.231.237.45]:59404 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752781AbcLLVRy (ORCPT ); Mon, 12 Dec 2016 16:17:54 -0500 Subject: Re: [PATCH 1/1] Fixed to codestyle To: Joe Perches , Ozgur Karatas , "david@fromorbit.com" References: <987271481540010@web27o.yandex.ru> <66c68b88-e338-1d9a-b9dd-b8d858ebf349@sandeen.net> <1481566450.1764.23.camel@perches.com> <50420874-ffde-283f-f2e7-cb2ebbec1b84@sandeen.net> <737751481574841@web26j.yandex.ru> <1481575838.1764.39.camel@perches.com> Cc: "linux-xfs@vger.kernel.org" , linux-kernel From: Eric Sandeen Message-ID: <0b7ecb73-6d9a-a1c0-f006-4764ce07d5ab@sandeen.net> Date: Mon, 12 Dec 2016 15:17:52 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481575838.1764.39.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 23 On 12/12/16 2:50 PM, Joe Perches wrote: > On Mon, 2016-12-12 at 14:41 -0600, Eric Sandeen wrote: >> On 12/12/16 2:34 PM, Ozgur Karatas wrote: > [] >>> Can you tell me the true code style? should use to (* uuid)? >>> I'm learn to new and I'm newbies :) >> >> Well, rule #1 for newbies is "code style patches aren't >> very useful, and usually are not welcomed by the project." > > I'd amend that to > > "newbies should only use checkpatch on files in drivers/staging/" > > and are generally welcome to do exactly that in order to learn > how to submit patches appropriately before finding something > actually useful to change in other areas of the kernel. Ok, that's a fair amendment. :) -Eric