Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672AbcLLVxr (ORCPT ); Mon, 12 Dec 2016 16:53:47 -0500 Received: from [65.99.196.166] ([65.99.196.166]:50255 "EHLO namei.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752088AbcLLVxq (ORCPT ); Mon, 12 Dec 2016 16:53:46 -0500 Date: Tue, 13 Dec 2016 08:53:11 +1100 (AEDT) From: James Morris To: David Howells cc: Pan Bian , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-module@vger.kernel.org, Herbert Xu Subject: Re: [PATCH 1/2] crypto: asymmetric_keys: set error code on failure In-Reply-To: <148155941173.13547.18287868065423253267.stgit@warthog.procyon.org.uk> Message-ID: References: <148155941173.13547.18287868065423253267.stgit@warthog.procyon.org.uk> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1140 Lines: 39 On Mon, 12 Dec 2016, David Howells wrote: > From: Pan Bian > > In function public_key_verify_signature(), returns variable ret on > error paths. When the call to kmalloc() fails, the value of ret is 0, > and it is not set to an errno before returning. This patch fixes the > bug. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891 > > Signed-off-by: Pan Bian > Signed-off-by: David Howells > --- These crypto patches should probably go via Herbert's tree. > > crypto/asymmetric_keys/public_key.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c > index fd76b5fc3b3a..d3a989e718f5 100644 > --- a/crypto/asymmetric_keys/public_key.c > +++ b/crypto/asymmetric_keys/public_key.c > @@ -121,6 +121,7 @@ int public_key_verify_signature(const struct public_key *pkey, > if (ret) > goto error_free_req; > > + ret = -ENOMEM; > outlen = crypto_akcipher_maxsize(tfm); > output = kmalloc(outlen, GFP_KERNEL); > if (!output) > -- James Morris