Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932474AbcLLWcS (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Dec 2016 17:32:18 -0500
Received: from smtprelay0097.hostedemail.com ([216.40.44.97]:55889 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S932282AbcLLWcQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Dec 2016 17:32:16 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:967:982:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2525:2560:2563:2682:2685:2693:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3834:3865:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6117:8599:9025:9388:10004:10049:10400:10848:11026:11027:11232:11473:11657:11658:11914:12043:12296:12438:12555:12682:12740:12760:12776:13069:13311:13357:13439:14107:14181:14659:14721:14849:21080:21433:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none
X-HE-Tag: force11_87df1516c710f
X-Filterd-Recvd-Size: 2051
Message-ID: <1481581932.29291.6.camel@perches.com>
Subject: Re: [PATCH] ACPI: small formatting fixes
From: Joe Perches <joe@perches.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Nick Desaulniers <nick.desaulniers@gmail.com>, rjw@rjwysocki.net,
        len.brown@intel.com, tglx@linutronix.de, mingo@redhat.com,
        hpa@zytor.com, x86@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Mon, 12 Dec 2016 14:32:12 -0800
In-Reply-To: <20161212222216.GA18201@amd>
References: <20161212072541.28435-1-nick.desaulniers@gmail.com>
         <20161212085620.GA738@amd> <20161212175654.ydc7rx3edqoacnp7@lostoracle.net>
         <1481567955.1764.28.camel@perches.com> <20161212222216.GA18201@amd>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.1-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1005
Lines: 29

On Mon, 2016-12-12 at 23:22 +0100, Pavel Machek wrote:
> On Mon 2016-12-12 10:39:15, Joe Perches wrote:
> > On Mon, 2016-12-12 at 09:56 -0800, Nick Desaulniers wrote:
> > > A quick cleanup that passes scripts/checkpatch.pl -f <file>.
[]
> > > diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
[]
> > It's generally better not to convert
> > these printk(KERN_DEBUG uses.
> > 
> > There are behavior differences between
> > 	printk(KERN_DEBUG ...);
> > and
> > 	pr_debug(...);
> > 
> > The first will always be emitted as long
> > as the console level is appropriate.
> > 
> > The second depends on a #define DEBUG
> > before it gets emitted or a kernel 
> > with CONFIG_DYNAMIC_DEBUG enabled and
> > this entry specifically enabled in the
> > control file.
> 
> Hmm. Perhaps pr_debug should be called pr_c_debug() or something? This
> is rather nice trap.

Yeah, I've suggested veriants like pr_always_debug (from 2009)
http://lkml.iu.edu/hypermail/linux/kernel/0910.0/00399.html