Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753033AbcLLXnf (ORCPT ); Mon, 12 Dec 2016 18:43:35 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:33708 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752184AbcLLXnd (ORCPT ); Mon, 12 Dec 2016 18:43:33 -0500 MIME-Version: 1.0 In-Reply-To: <1481306510-7471-3-git-send-email-irina.tirdea@intel.com> References: <1481306510-7471-1-git-send-email-irina.tirdea@intel.com> <1481306510-7471-3-git-send-email-irina.tirdea@intel.com> From: Andy Shevchenko Date: Tue, 13 Dec 2016 01:43:31 +0200 Message-ID: Subject: Re: [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 To: Irina Tirdea Cc: linux-clk@vger.kernel.org, "x86@kernel.org" , platform-driver-x86@vger.kernel.org, Stephen Boyd , Darren Hart , Thomas Gleixner , Michael Turquette , Ingo Molnar , "H. Peter Anvin" , ALSA Development Mailing List , Mark Brown , Takashi Iwai , Pierre-Louis Bossart , "Rafael J. Wysocki" , Len Brown , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 34 I have been told I have to send my comments here instead of our internal ML. I didn't fast enough to comment that during v5. So do it right now. On Fri, Dec 9, 2016 at 8:01 PM, Irina Tirdea wrote: > The pmc_atom driver does not contain any architecture specific > code. It only enables the SOC Power Management Controller Driver SOC -> SoC Driver -> driver > for BayTrail and CherryTrail platforms. > > Move the pmc_atom driver from arch/x86/platform/atom to > drivers/platform/x86. > > Signed-off-by: Irina Tirdea > --- > arch/x86/Kconfig | 4 ---- > arch/x86/platform/atom/Makefile | 1 - > drivers/acpi/acpi_lpss.c | 2 +- > drivers/platform/x86/Kconfig | 4 ++++ > drivers/platform/x86/Makefile | 1 + > {arch/x86/platform/atom => drivers/platform/x86}/pmc_atom.c | 3 +-- > {arch/x86/include/asm => include/linux/platform_data/x86}/pmc_atom.h | 0 No, it's not a *platform data*. Other that that looks good to me. -- With Best Regards, Andy Shevchenko