Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932477AbcLMAPV (ORCPT ); Mon, 12 Dec 2016 19:15:21 -0500 Received: from mga07.intel.com ([134.134.136.100]:48551 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707AbcLMAPS (ORCPT ); Mon, 12 Dec 2016 19:15:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="797267305" Subject: Re: [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks To: Andy Shevchenko , Irina Tirdea References: <1481306510-7471-1-git-send-email-irina.tirdea@intel.com> <1481306510-7471-2-git-send-email-irina.tirdea@intel.com> Cc: linux-clk@vger.kernel.org, "x86@kernel.org" , platform-driver-x86@vger.kernel.org, Stephen Boyd , Darren Hart , Thomas Gleixner , Michael Turquette , Ingo Molnar , "H. Peter Anvin" , ALSA Development Mailing List , Mark Brown , Takashi Iwai , Pierre-Louis Bossart , "Rafael J. Wysocki" , Len Brown , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Pierre-Louis Bossart Message-ID: <1a98dcda-a662-958e-307f-5fe3f281ed9f@linux.intel.com> Date: Mon, 12 Dec 2016 18:15:09 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1533 Lines: 43 > Thanks for an update I will comment all the patches. > Here we start. Thanks Andy for the review. Two quick comments before going further in the details later. > >> The BayTrail and CherryTrail platforms provide platform clocks >> through their Power Management Controller (PMC). >> >> The SoC supports up to 6 clocks (PMC_PLT_CLK[5:0]) with a >> frequency of either 19.2 MHz (PLL) or 25 MHz (XTAL) for BayTrail >> and a frequency of 19.2 MHz (XTAL) for CherryTrail. These clocks >> are available for general system use, where appropriate, and each >> have Control & Frequency register fields associated with them. >> >> Signed-off-by: Irina Tirdea >> Signed-off-by: Pierre-Louis Bossart > > Who is the actual author? SoB I guess should be either the author, or > 1st, 2nd, ..., last one who is submitter. I ported the initial code from Android legacy stuff and Irina ported the functionality to the clk framework. It seems appropriate to have both signed-offs? [snip] > >> +#include This was a suggestion of Darren Hart in agreement with Thomas Gleixner. see http://mailman.alsa-project.org/pipermail/alsa-devel/2016-October/113936.html Darren, did we get your proposal right? > > Is it indeed platform data? I would not create platform_data/x86 > without strong argument. > Perhaps include/linux/clk/x86_pmc.h? (Yes, I know about clk-lpss.h > which is old enough and was basically first try of clk stuff on x86)