Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753409AbcLMDpm (ORCPT ); Mon, 12 Dec 2016 22:45:42 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:53545 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752937AbcLMDpi (ORCPT ); Mon, 12 Dec 2016 22:45:38 -0500 Date: Tue, 13 Dec 2016 11:45:24 +0800 From: Herbert Xu To: James Morris Cc: David Howells , Pan Bian , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-module@vger.kernel.org Subject: Re: [PATCH 1/2] crypto: asymmetric_keys: set error code on failure Message-ID: <20161213034524.GE5601@gondor.apana.org.au> References: <148155941173.13547.18287868065423253267.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 950 Lines: 28 On Tue, Dec 13, 2016 at 08:53:11AM +1100, James Morris wrote: > On Mon, 12 Dec 2016, David Howells wrote: > > > From: Pan Bian > > > > In function public_key_verify_signature(), returns variable ret on > > error paths. When the call to kmalloc() fails, the value of ret is 0, > > and it is not set to an errno before returning. This patch fixes the > > bug. > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891 > > > > Signed-off-by: Pan Bian > > Signed-off-by: David Howells > > --- > > These crypto patches should probably go via Herbert's tree. OK but someone will need to post them to linux-crypto first. I know the originals went that way but David's repost doesn't seem to be in patchwork. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt