Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932475AbcLMEIi convert rfc822-to-8bit (ORCPT ); Mon, 12 Dec 2016 23:08:38 -0500 Received: from linuxhacker.ru ([217.76.32.60]:41700 "EHLO fiona.linuxhacker.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932188AbcLMEIg (ORCPT ); Mon, 12 Dec 2016 23:08:36 -0500 Subject: Re: [PATCH 0/8] Sparse warning fixes in Lustre. Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Oleg Drokin In-Reply-To: <20161207234639.GU1555@ZenIV.linux.org.uk> Date: Mon, 12 Dec 2016 23:07:53 -0500 Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , James Simmons , Linux Kernel Mailing List , Lustre Development List Content-Transfer-Encoding: 8BIT Message-Id: <8062BE1A-1674-4643-92C4-1E0A4C6E2477@linuxhacker.ru> References: <1481150494-1853127-1-git-send-email-green@linuxhacker.ru> <20161207234639.GU1555@ZenIV.linux.org.uk> To: Al Viro X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 823 Lines: 20 On Dec 7, 2016, at 6:46 PM, Al Viro wrote: > On Wed, Dec 07, 2016 at 05:41:26PM -0500, Oleg Drokin wrote: >> This set of fixes aims at sparse warnings. > > Speaking of the stuff sparse catches there: class_process_proc_param(). > I've tried to describe what I think of that Fine Piece Of Software > several times, but I had to give up - my command of obscenity is not > up to the task, neither in English nor in Russian. Please, take it > out. Preferably - along with the ->ldo_process_config()/->process_config() > thing. Well, I can guess what you don't like in the remnants of the "well, we have uniform procfs, so let's use that to our advantage and simplify or config parsing". But what's your beef with ldo_process_config()/->process_config(), I wonder? Just a way to propagate config info across the layers.