Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932506AbcLMIrn (ORCPT ); Tue, 13 Dec 2016 03:47:43 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:57680 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752937AbcLMIrk (ORCPT ); Tue, 13 Dec 2016 03:47:40 -0500 Subject: Re: [PATCH v6 4/5] ARM: dts: da850-lcdk: add the vga-bridge node To: Bartosz Golaszewski References: <1481547942-24775-1-git-send-email-bgolaszewski@baylibre.com> <1481547942-24775-5-git-send-email-bgolaszewski@baylibre.com> CC: Jyri Sarha , David Airlie , Kevin Hilman , Michael Turquette , Sekhar Nori , Rob Herring , Frank Rowand , Mark Rutland , Laurent Pinchart , Peter Ujfalusi , Russell King , LKML , arm-soc , linux-drm , linux-devicetree From: Tomi Valkeinen Message-ID: <9d5fa409-bb4f-f62b-2548-0a3b82228e08@ti.com> Date: Tue, 13 Dec 2016 10:46:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481547942-24775-5-git-send-email-bgolaszewski@baylibre.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2xMBPNrwB41GkK2hgX9fwGc1ESl9rhVn5" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3271 Lines: 99 --2xMBPNrwB41GkK2hgX9fwGc1ESl9rhVn5 Content-Type: multipart/mixed; boundary="muXGduK0IrB2IRpfmL1B5TsELpNW97HIN"; protected-headers="v1" From: Tomi Valkeinen To: Bartosz Golaszewski Cc: Jyri Sarha , David Airlie , Kevin Hilman , Michael Turquette , Sekhar Nori , Rob Herring , Frank Rowand , Mark Rutland , Laurent Pinchart , Peter Ujfalusi , Russell King , LKML , arm-soc , linux-drm , linux-devicetree Message-ID: <9d5fa409-bb4f-f62b-2548-0a3b82228e08@ti.com> Subject: Re: [PATCH v6 4/5] ARM: dts: da850-lcdk: add the vga-bridge node References: <1481547942-24775-1-git-send-email-bgolaszewski@baylibre.com> <1481547942-24775-5-git-send-email-bgolaszewski@baylibre.com> In-Reply-To: <1481547942-24775-5-git-send-email-bgolaszewski@baylibre.com> --muXGduK0IrB2IRpfmL1B5TsELpNW97HIN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, On 12/12/16 15:05, Bartosz Golaszewski wrote: > +&lcdc { > + status =3D "okay"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&lcd_pins>; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + lcdc_out: port@1 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <1>; > + > + lcdc_out_vga: endpoint { > + reg =3D <0>; > + remote-endpoint =3D <&vga_bridge_in>; > + }; > + }; > + }; > +}; >=20 This is not correct. LCDC has just one output, so port@1 doesn't make sense. It's port@0. But with just one port, you can leave "ports" away. And you don't need the port's label for anything, if I'm not mistaken. So= : &lcdc { status =3D "okay"; pinctrl-names =3D "default"; pinctrl-0 =3D <&lcd_pins>; port { lcdc_out_vga: endpoint { remote-endpoint =3D <&vga_bridge_in>; }; }; }; Tomi --muXGduK0IrB2IRpfmL1B5TsELpNW97HIN-- --2xMBPNrwB41GkK2hgX9fwGc1ESl9rhVn5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYT7V0AAoJEPo9qoy8lh71jbwQALG4a8TrujmZr/7Meq0jgjWa 7/kUmbM3Iq5Ru9w9rN0jP8jkZVJrcOnnrk+3WgiskmiIfZTGnI+fWtP7CjLGLwuX EQsWZEyrVEF0SMXxE4yjCGeE5fTM85yltlZkhbO3iFbOmCKDfVqB6BqpBVsp2Uzq ZU5XNsvQl6DSEnIRKVjNcEYpjDO4gdefjNzevjtBlrRImB1L/t2vCiuz9NKST5cl q/vQlprtj+SUVgHbp5PzoEITxaeaMKGrkw2u0AHK3WM6d3qfM5Nv4lvgL/avUNhm +TaA/xq5NJhSB2Wn0d02YAhYC886M7VxUSAoNqvrlLhNBJKSLE30GbKZ37KH3t9J ljUAswxBCFXnppdRt2lUtgP65SIq4VKbj0QpuNiFGxEhFR1ZG6fKH8dHqpx4GhRc IFdxd3dx+YjGObBAW5vXf4tBC9+pHMAgrI9vhM4eqz8/mqE/ub/kfYc0MVf0PdOs CWszIztmFmDUIVkm8/mANFTbX4wHS6TSefYvMWGbW6tpSSbJ7S8jvG9y2BPZybX8 ewZv47rvgEgyxTd946JTqgbcf/ajgA91PQX9WvxU8C0RsR3+wOWXSRr9/nGmkEuC x3FFRDhy97zaLmbRTBBNAFOD5RrG6dT6TcJonpIFc9c01DiegopboAllaGvih26a pKFjzXcRXMyCVvVB7e0X =bvSo -----END PGP SIGNATURE----- --2xMBPNrwB41GkK2hgX9fwGc1ESl9rhVn5--