Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481AbcLMJP7 (ORCPT ); Tue, 13 Dec 2016 04:15:59 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:34106 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753055AbcLMJPy (ORCPT ); Tue, 13 Dec 2016 04:15:54 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Tue, 13 Dec 2016 09:16:37 +0000 From: Charles Keepax To: Nicholas Mc Guire CC: Michael Turquette , Mark Brown , Stephen Boyd , , , Subject: Re: [PATCH RFC] clk: wm831x: fix usleep_range with bad range Message-ID: <20161213091637.GM1867@localhost.localdomain> References: <1481528409-5182-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1481528409-5182-1-git-send-email-hofrat@osadl.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1612130161 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 633 Lines: 17 On Mon, Dec 12, 2016 at 08:40:09AM +0100, Nicholas Mc Guire wrote: > The delay here is not in atomic context and does not seem critical with > respect to precision, but usleep_range(min,max) with min==max results in > giving the timer subsystem no room to optimize uncritical delays. Fix > this by setting the range to 2000,3000 us. > > Fixes: commit f05259a6ffa4 ("clk: wm831x: Add initial WM831x clock driver") > Signed-off-by: Nicholas Mc Guire > --- Yeah looks fine waiting longer for the FLL to lock won't cause any issues. Acked-by: Charles Keepax Thanks, Charles