Subject: Re: [PATCH 1/2] ARM: nommu: allow enabling REMAP_VECTORS_TO_RAM
To: Afzal Mohammed <afzal.mohd.ma@gmail.com>,
        Russell King <linux@armlinux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20161211131028.3019-1-afzal.mohd.ma@gmail.com>
 <20161211131158.3120-1-afzal.mohd.ma@gmail.com>
From: Vladimir Murzin <vladimir.murzin@arm.com>
Message-ID: <584FBCAC.5010700@arm.com>
Date: Tue, 13 Dec 2016 09:17:32 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20161211131158.3120-1-afzal.mohd.ma@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1196
Lines: 31

On 11/12/16 13:11, Afzal Mohammed wrote:
> REMAP_VECTORS_TO_RAM depends on DRAM_BASE, but since DRAM_BASE is a
> hex, REMAP_VECTORS_TO_RAM could never get enabled. Also depending on
> DRAM_BASE is redundant as whenever REMAP_VECTORS_TO_RAM makes itself
> available to Kconfig, DRAM_BASE also is available as the Kconfig gets
> sourced on !MMU.
> 
> Signed-off-by: Afzal Mohammed <afzal.mohd.ma@gmail.com>
> ---
>  arch/arm/Kconfig-nommu | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/Kconfig-nommu b/arch/arm/Kconfig-nommu
> index aed66d5df7f1..b7576349528c 100644
> --- a/arch/arm/Kconfig-nommu
> +++ b/arch/arm/Kconfig-nommu
> @@ -34,8 +34,7 @@ config PROCESSOR_ID
>  	  used instead of the auto-probing which utilizes the register.
>  
>  config REMAP_VECTORS_TO_RAM
> -	bool 'Install vectors to the beginning of RAM' if DRAM_BASE
> -	depends on DRAM_BASE
> +	bool 'Install vectors to the beginning of RAM'
>  	help
>  	  The kernel needs to change the hardware exception vectors.
>  	  In nommu mode, the hardware exception vectors are normally
> 

I have similar change in my local tree, so FWIW:

Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>