Subject: Re: [PATCH 7/7] blk-mq-sched: allow setting of default IO scheduler
To: Jens Axboe <axboe@fb.com>, <axboe@kernel.dk>,
        <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1481228005-9245-1-git-send-email-axboe@fb.com>
 <1481228005-9245-8-git-send-email-axboe@fb.com>
CC: <paolo.valente@linaro.org>, <osandov@fb.com>
From: Bart Van Assche <bart.vanassche@sandisk.com>
Message-ID: <3e4483e3-6018-5c6c-9fe2-128ed68c01f4@sandisk.com>
Date: Tue, 13 Dec 2016 11:13:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.0
MIME-Version: 1.0
In-Reply-To: <1481228005-9245-8-git-send-email-axboe@fb.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2016 10:14:01.1098 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB1682
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 604
Lines: 23

On 12/08/2016 09:13 PM, Jens Axboe wrote:
> +config DEFAULT_MQ_IOSCHED
> +	string
> +	default "mq-deadline" if DEFAULT_MQ_DEADLINE
> +	default "none" if DEFAULT_MQ_NONE
> +
>  endmenu
>
> +config MQ_IOSCHED_ONLY_SQ
> +	bool "Enable blk-mq IO scheduler only for single queue devices"
> +	default y
> +	help
> +	  Say Y here, if you only want to enable IO scheduling on block
> +	  devices that have a single queue registered.
> +
>  endif

Hello Jens,

Shouln't the MQ_IOSCHED_ONLY_SQ entry be placed before "endmenu" such 
that it is displayed in the I/O scheduler menu instead of the block menu?

Bart.