Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932763AbcLMLCp (ORCPT ); Tue, 13 Dec 2016 06:02:45 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:52043 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932464AbcLMLCn (ORCPT ); Tue, 13 Dec 2016 06:02:43 -0500 Subject: Re: [PATCH] spi: armada-3700: fix unsigned compare than zero on irq To: Colin King , Mark Brown , linux-spi@vger.kernel.org References: <20161213102812.9029-1-colin.king@canonical.com> Cc: linux-kernel@vger.kernel.org From: Romain Perier Message-ID: <571b3162-2a92-ef31-3300-ac931fbcceb5@free-electrons.com> Date: Tue, 13 Dec 2016 12:02:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 348 Lines: 16 Hello, Le 13/12/2016 à 11:55, Romain Perier a écrit : >> > > Why don't you change only the type of "irq" in struct a3700_spi ? > > Thanks, > Romain In fact, it cannot work with devmem_request_irq/request_irq which require an unsigned int as second argument... So it's okay for me. Acked-by: Romain Perier