Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933195AbcLMOJj (ORCPT ); Tue, 13 Dec 2016 09:09:39 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:40522 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932254AbcLMOJh (ORCPT ); Tue, 13 Dec 2016 09:09:37 -0500 From: Laurent Pinchart To: Sylwester Nawrocki Cc: Nicholas Mc Guire , Mauro Carvalho Chehab , Sakari Ailus , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Date: Tue, 13 Dec 2016 16:10:09 +0200 Message-ID: <5277658.1FioEDcST1@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: References: <1481594282-12801-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBDE9lUE000821 Content-Length: 1017 Lines: 30 Hi Sylwester, On Tuesday 13 Dec 2016 13:38:52 Sylwester Nawrocki wrote: > On 12/13/2016 02:58 AM, Nicholas Mc Guire wrote: > > As this is not in atomic context and it does not seem like a critical > > timing setting a range of 1ms allows the timer subsystem to optimize > > the hrtimer here. > > > > Fixes: commit bfa8dd3a0524 ("[media] v4l: Add v4l2 subdev driver for > > S5K6AAFX sensor") Signed-off-by: Nicholas Mc Guire > > --- > > Acked-by: Sylwester Nawrocki > > I'm not sure the "Fixes" tag is needed here. > > > Patch is against 4.9.0 (localversion-next is next-20161212) > > Ideally patches for the media subsystem should be normally based on > master branch of the media tree (git://linuxtv.org/media_tree.git). As pointed out by Ian Arkver, the datasheet states the delay should be >50?s. Would it make sense to reduce the sleep duration to (3000, 4000) for instance (or possibly even lower), instead of increasing it ? -- Regards, Laurent Pinchart