Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933568AbcLMPF5 (ORCPT ); Tue, 13 Dec 2016 10:05:57 -0500 Received: from twin.jikos.cz ([89.185.236.188]:57263 "EHLO twin.jikos.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932346AbcLMPFx (ORCPT ); Tue, 13 Dec 2016 10:05:53 -0500 X-Greylist: delayed 1724 seconds by postgrey-1.27 at vger.kernel.org; Tue, 13 Dec 2016 10:05:52 EST Date: Tue, 13 Dec 2016 15:36:57 +0100 (CET) From: Jiri Kosina X-X-Sender: jikos@twin.jikos.cz To: Eduardo Valentin cc: Zhang Rui , Peter Foley , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] Fix multiple definition error under lto In-Reply-To: <20161213031819.GA9668@localhost.localdomain> Message-ID: References: <20161126222528.15261-1-pefoley2@pefoley.com> <1481514306.2325.1.camel@intel.com> <20161213031819.GA9668@localhost.localdomain> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 671 Lines: 19 On Mon, 12 Dec 2016, Eduardo Valentin wrote: > > > drivers/thermal/built-in.o: In function `type_show.lto_priv.33': > > > (.text+0x3d80): multiple definition of `type_show.lto_priv.33' > > > drivers/base/built-in.o:(.text+0x2a40): first defined here > > > > > can you illustrate how to reproduce this problem? > > same here. I am not able to see this. Can you please describe your > environment? I'm pretty sure he's experimenting with LTO and hitting the LTO phase getting link-time symbol conflicts between definitions coming from thermal and base. I'd even say this to be a toolchain bug, given the fact that both symbols are static. -- Jiri Kosina SUSE Labs