Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262470AbTENPQ2 (ORCPT ); Wed, 14 May 2003 11:16:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262354AbTENPOh (ORCPT ); Wed, 14 May 2003 11:14:37 -0400 Received: from pixpat.austin.ibm.com ([192.35.232.241]:60867 "EHLO baldur.austin.ibm.com") by vger.kernel.org with ESMTP id S262437AbTENPMv (ORCPT ); Wed, 14 May 2003 11:12:51 -0400 Date: Wed, 14 May 2003 10:25:26 -0500 From: Dave McCracken To: William Lee Irwin III cc: Andrew Morton , mika.penttila@kolumbus.fi, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: Race between vmtruncate and mapped areas? Message-ID: <51020000.1052925926@baldur.austin.ibm.com> In-Reply-To: <20030514150653.GM8978@holomorphy.com> References: <154080000.1052858685@baldur.austin.ibm.com> <20030513181018.4cbff906.akpm@digeo.com> <18240000.1052924530@baldur.austin.ibm.com> <20030514150653.GM8978@holomorphy.com> X-Mailer: Mulberry/2.2.1 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1373 Lines: 31 --On Wednesday, May 14, 2003 08:06:53 -0700 William Lee Irwin III wrote: >> Which the application thinks is still part of the file, and will expect >> its changes to be written back. Granted, if the page fault occurred >> just after the truncate it'd get SIGBUS, so it's clearly not a robust >> assumption, but it will result in unexpected behavior. Note that if the >> application later extends the file to include this page it could result >> in a corrupted file, since all the pages around it will be written >> properly. > > Well, for this one I'd say the app loses; it was its own failure to > synchronize truncation vs. access, at least given that the kernel > doesn't oops. I think allowing a race condition that can randomly leave corrupted files is a really bad idea, even if the app is doing something stupid. We know what the race is. We should be able to prevent it. Dave ====================================================================== Dave McCracken IBM Linux Base Kernel Team 1-512-838-3059 dmccr@us.ibm.com T/L 678-3059 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/