Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934150AbcLMQX0 (ORCPT ); Tue, 13 Dec 2016 11:23:26 -0500 Received: from mail.kernel.org ([198.145.29.136]:44230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753549AbcLMQXI (ORCPT ); Tue, 13 Dec 2016 11:23:08 -0500 Date: Tue, 13 Dec 2016 13:23:01 -0300 From: Arnaldo Carvalho de Melo To: Ravi Bangoria Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, chris.ryder@arm.com, mhiramat@kernel.org, kim.phillips@arm.com, treeze.taeung@gmail.com, markus@trippelsdorf.de, naveen.n.rao@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v8 2/3] perf annotate: Support jump instruction with target as second operand Message-ID: <20161213162301.GM5482@kernel.org> References: <1480953407-7605-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1480953407-7605-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480953407-7605-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 672 Lines: 20 Em Mon, Dec 05, 2016 at 09:26:46PM +0530, Ravi Bangoria escreveu: > +++ b/tools/perf/util/annotate.c > @@ -223,8 +223,12 @@ bool ins__is_call(const struct ins *ins) > static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *ops, struct map *map __maybe_unused) > { > const char *s = strchr(ops->raw, '+'); > + const char *c = strchr(ops->raw, ','); > > - ops->target.addr = strtoull(ops->raw, NULL, 16); > + if (c++ != NULL) > + ops->target.addr = strtoull(c, NULL, 16); > + else > + ops->target.addr = strtoull(ops->raw, NULL, 16); > > if (s++ != NULL) > ops->target.offset = strtoull(s, NULL, 16); Simple enough, applied. - Arnaldo