Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934245AbcLMRCd (ORCPT ); Tue, 13 Dec 2016 12:02:33 -0500 Received: from 4.mo4.mail-out.ovh.net ([178.32.98.131]:42503 "EHLO 4.mo4.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932542AbcLMRCI (ORCPT ); Tue, 13 Dec 2016 12:02:08 -0500 Subject: Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in spi_nor_write() To: Boris Brezillon , Cyrille Pitchen References: <0078578d0f5d2402ac623afabf601d25998f84a9.1481044434.git.cyrille.pitchen@atmel.com> <20161208163109.17429627@bbrezillon> Cc: marek.vasut@gmail.com, computersforpeace@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, richard@nod.at From: Cyrille Pitchen Message-ID: <4ffbad4b-f1a5-a998-fe5b-f73b934435e4@wedev4u.fr> Date: Tue, 13 Dec 2016 17:43:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161208163109.17429627@bbrezillon> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 2688367504190953281 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelfedrieeggdeflecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1770 Lines: 44 Le 08/12/2016 ? 16:31, Boris Brezillon a ?crit : > On Tue, 6 Dec 2016 18:14:24 +0100 > Cyrille Pitchen wrote: > >> This patch removes the WARN_ONCE() test in spi_nor_write(). >> This macro triggers the display of a warning message almost every time we >> use a UBI file-system because a write operation is performed at offset 64, >> which is in the middle of the SPI NOR memory page. This is a valid >> operation for ubifs. >> >> Hence this warning is pretty annoying and useless so we just remove it. >> >> Signed-off-by: Cyrille Pitchen >> Suggested-by: Richard Weinberger >> Suggested-by: Andras Szemzo > > Acked-by: Boris Brezillon > Applied to git://github.com/spi-nor/linux.git >> --- >> drivers/mtd/spi-nor/spi-nor.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >> index c9bcd05ca5d9..cdeb2c6b1492 100644 >> --- a/drivers/mtd/spi-nor/spi-nor.c >> +++ b/drivers/mtd/spi-nor/spi-nor.c >> @@ -1265,9 +1265,6 @@ static int spi_nor_write(struct mtd_info *mtd, loff_t to, size_t len, >> ssize_t written; >> >> page_offset = (to + i) & (nor->page_size - 1); >> - WARN_ONCE(page_offset, >> - "Writing at offset %zu into a NOR page. Writing partial pages may decrease reliability and increase wear of NOR flash.", >> - page_offset); >> /* the size of data remaining on the first page */ >> page_remain = min_t(size_t, >> nor->page_size - page_offset, len - i); > > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ >