From: Arnd Bergmann <arnd@arndb.de>
To: Max Bires <jbires@google.com>
Cc: gregkh@linuxfoundation.org, josh@joshtriplett.org,
        linux-kernel@vger.kernel.org
Subject: Re: /drivers/char/Kconfig Bug Kernel Patch
Date: Tue, 13 Dec 2016 22:37:58 +0100
Message-ID: <25312310.aENfjP0Zdi@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CALVgH4QHDYw=j4k2iogL4FTvLXMExi6GqrskQoQ0bxP1MjN0Ew@mail.gmail.com>
References: <CALVgH4QHDYw=j4k2iogL4FTvLXMExi6GqrskQoQ0bxP1MjN0Ew@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 891
Lines: 21

On Tuesday, December 13, 2016 1:30:39 PM CET Max Bires wrote:
> While trying to turn off the port device in defconfig, I ran into a bug
> caused by the fact that the Kconfig for port didn't have a string after the
> bool declaration. I fixed this in the attached patch (though I figure the
> description might need tuning up). Let me know if there's anything else I
> need to do.

The change looks reasonable, however there are a few things to improve
to get the patch applied:

- clarify that the current behavior is not a bug, but was done intentionally.
  Making the option user-visible would help avoid a potential attack vector
  and make the kernel smaller, both of which are useful.

- remove the "Change-id" line from the submission, it has no meaning in 
  an upstream kernel

- send the patch inline rather than as an attachment, this is usually done
  with git-send-email.

	Arnd