Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263183AbTENQ76 (ORCPT ); Wed, 14 May 2003 12:59:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263239AbTENQ76 (ORCPT ); Wed, 14 May 2003 12:59:58 -0400 Received: from pao-ex01.pao.digeo.com ([12.47.58.20]:22877 "EHLO pao-ex01.pao.digeo.com") by vger.kernel.org with ESMTP id S263183AbTENQ74 (ORCPT ); Wed, 14 May 2003 12:59:56 -0400 Date: Wed, 14 May 2003 10:14:02 -0700 From: Andrew Morton To: ebiederm@xmission.com (Eric W. Biederman) Cc: andyp@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [KEXEC][2.5.69] Re: Updated kexec diffs... Message-Id: <20030514101402.79178a7c.akpm@digeo.com> In-Reply-To: References: <3EBA626E.6040205@cyberone.com.au> <20030508121211.532dcbcf.akpm@digeo.com> <3EBC37C4.9090602@cyberone.com.au> <20030509162911.2cd5321e.akpm@digeo.com> <20030509201327.734caf9e.akpm@digeo.com> <20030511121753.7a883afb.akpm@digeo.com> <1052861167.1324.15.camel@andyp.pdx.osdl.net> <20030513222343.74a3d817.akpm@digeo.com> X-Mailer: Sylpheed version 0.9.0pre1 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 14 May 2003 17:12:39.0886 (UTC) FILETIME=[06144EE0:01C31A3C] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 636 Lines: 16 ebiederm@xmission.com (Eric W. Biederman) wrote: > > Is it more of a help or a hindrance to use gcc noreturn > tag? It seems to be a significant hassle - it propagates all over the place and makes one curse. It's like retroconstification, as you say. I'd be inclined to leave the function prototypes as-is and stick a commented while(1); in those places which actually need it, frankly. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/