Date: Tue, 13 Dec 2016 16:58:47 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: Max <jbires@google.com>
Cc: arnd@arndb.de, josh@joshtriplett.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on
Message-ID: <20161214005847.GB1141@kroah.com>
References: <1481675545-84255-1-git-send-email-jbires@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1481675545-84255-1-git-send-email-jbires@google.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1330
Lines: 41

On Tue, Dec 13, 2016 at 04:32:25PM -0800, Max wrote:
> From: Max Bires <jbires@google.com>
> 
> Without a bool string present, using "# CONFIG_DEVPORT is not set" in
> defconfig files would not actually unset devport. This ensured that
> /dev/port was always on, but there are reasons a user may wish to disable
> it (smaller kernel, attack surface reduction) if it's not being used. Adding
> a message here in order to make this user visible.
> 
> Signed-off-by: Max Bires <jbires@google.com>
> ---
>  drivers/char/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 7ad3127..d647e7e 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -589,10 +589,13 @@ config TELCLOCK
>  	  controlling the behavior of this hardware.
>  
>  config DEVPORT
> -	bool
> +	bool "/dev/port character device"
>  	depends on !M68K
>  	depends on ISA || PCI
>  	default y
> +	help
> +		Say Y here if you want to support the /dev/port device. The
> +		/dev/port device is similar to /dev/mem, but for I/O ports.


Hm, did you look at how the indentation for all of the help entries are
in this file?  Please match it up to be the same...

Other than that, this looks much better, the format and style of the
submission was fine.

thanks,

greg k-h