Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753300AbcLNB0t (ORCPT ); Tue, 13 Dec 2016 20:26:49 -0500 Received: from mail-pf0-f177.google.com ([209.85.192.177]:33131 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753038AbcLNB0r (ORCPT ); Tue, 13 Dec 2016 20:26:47 -0500 From: Max To: arnd@arndb.de Cc: gregkh@linuxfoundation.org, josh@joshtriplett.org, linux-kernel@vger.kernel.org, Max Subject: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Date: Tue, 13 Dec 2016 17:18:23 -0800 Message-Id: <1481678303-91161-1-git-send-email-jbires@google.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 In-Reply-To: <20161214005847.GB1141@kroah.com> References: <20161214005847.GB1141@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 32 Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This ensured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible. Signed-off-by: Max Bires --- drivers/char/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig index 7ad3127..e8fc493 100644 --- a/drivers/char/Kconfig +++ b/drivers/char/Kconfig @@ -589,10 +589,13 @@ config TELCLOCK controlling the behavior of this hardware. config DEVPORT - bool + bool "/dev/port character device" depends on !M68K depends on ISA || PCI default y + help + Say Y here if you want to support the /dev/port device. The + /dev/port device is similar to /dev/mem, but for I/O ports. config DCC_TTY tristate "DCC tty driver" -- 2.8.0.rc3.226.g39d4020