Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754248AbcLNBzD (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Dec 2016 20:55:03 -0500
Received: from mail-oi0-f65.google.com ([209.85.218.65]:33051 "EHLO
        mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751977AbcLNBzB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Dec 2016 20:55:01 -0500
MIME-Version: 1.0
In-Reply-To: <201612111140.48561@pali>
References: <20161208123618.28603-1-kernel@kempniu.pl> <20161208123618.28603-5-kernel@kempniu.pl>
 <201612111140.48561@pali>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Wed, 14 Dec 2016 03:54:59 +0200
Message-ID: <CAHp75VfTLrY_MBphzg2idGhQbvnjyf7+9-BQjD37TXnucj+nMw@mail.gmail.com>
Subject: Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set()
To: =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= <kernel@kempniu.pl>,
        Richard Purdie <rpurdie@rpsys.net>,
        Jacek Anaszewski <j.anaszewski@samsung.com>,
        Matthew Garrett <mjg59@srcf.ucam.org>,
        Darren Hart <dvhart@infradead.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Louis Davis <Louis_Davis@dell.com>,
        Jim Dailey <Jim_Dailey@dell.com>, Alex Hung <alex.hung@canonical.com>,
        Hui Wang <hui.wang@canonical.com>, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBE1t9kl012497
Content-Length: 795
Lines: 28

On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Thursday 08 December 2016 13:36:15 Michał Kępień wrote:
>> All calls to dell_app_wmi_led_set() have been replaced with direct
>> calls to dell_micmute_led_set(), so the former can be safely removed
>> along with its related enum.
>>
>> Signed-off-by: Michał Kępień <kernel@kempniu.pl>
>
> I would suggest to squash patches 2,3,4 into one. But I let decision to
> alsa & led maintainers.

I don't like the part where we are exporting something for just one
moment. So, +1 to squashed version.

>
> Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup
>
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
>
> --
> Pali Rohár
> pali.rohar@gmail.com



-- 
With Best Regards,
Andy Shevchenko