Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754777AbcLNEIu (ORCPT <rfc822;w@1wt.eu>);
        Tue, 13 Dec 2016 23:08:50 -0500
Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:35043 "EHLO
        mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1754684AbcLNEIr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Dec 2016 23:08:47 -0500
Subject: Re: [PATCH] block_dev: don't update file access position for sync
 direct IO
To: Shaohua Li <shli@fb.com>, <linux-block@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <d78aaba0928aa012d13eb462bbfc33cdddd0621a.1481684697.git.shli@fb.com>
CC: <kernel-team@fb.com>, Christoph Hellwig <hch@lst.de>
From: Jens Axboe <axboe@fb.com>
Message-ID: <58920289-6947-c079-6d96-779408436aeb@fb.com>
Date: Tue, 13 Dec 2016 21:08:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <d78aaba0928aa012d13eb462bbfc33cdddd0621a.1481684697.git.shli@fb.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [66.29.164.166]
X-ClientProxiedBy: BLUPR17CA0040.namprd17.prod.outlook.com (10.164.14.178) To
 BN6PR15MB1185.namprd15.prod.outlook.com (10.172.205.139)
X-MS-Office365-Filtering-Correlation-Id: dd0e83c4-a0df-47d4-c6ed-08d423d6d94f
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR15MB1185;
X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;3:yZOxYdbXzX94Vo+swrKevpC9s7gSniAaQ1ADWAu/n6a9i8dhM8FCwkA0s9VZZdpUNsp+zyRHJL6pig2f8Wc8tgCtW9sbn0ruCpEf+cyysF89R6VTNE+zm0nE9lZc2Us0J5Q9y66rTcKyZb6GRtBq5DGlDh565rKJxkWNfzPtP4FKBDuTPPcGY1HHCtnzznnApe3o0FCP/1Tm4GSPlIxs0eaMZomhUsyAOvCN9ooWzdl2A8JXvv+4nZHoFEZqwA8aj1K7rFi2pTuEWHjhp3elOw==
X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;25:0Im2XkXuGX5sSUhGKsTuAbgDc0OXLy8AzFMSgsggHv70yanzDmGFA/s2dqbU9sn2T7GEoRNpY3eSmiCKsz08RV0f8xxgbU2n1JbD/RKeod/sWLOQ8OEN64tDO0DaUY0onQjyqgA4GVaV3GeB0HEHwlilmLUfk7mQ1AXfKfmLUiIZ053yEZVLgD12JSdlQOdC5hQKEKkBwB1OIkIE5rZ7pOvYnZuYfsSP68DeP+MIRPSw686Izh6XfCeSlipf69mUAvuSaHWOVoIL8ew0D2WZHy+++Uz8W8uBQYWdEI4K82HmOraXoYNPo6zrXbneOCH9evFty5F5eg0Mn2cPq3tWRKagkTHrMHtFx63IDPLveQzRTj79lEeXtz9oh6e5CRPGS4mWkTquL9MH77F+iq4X/uql41oDF+FUTYxrhj2GIGjZYCYykwZ4S3qPwDSXik1RziJe6dTTvSJ9TOpTxoyVv7FCe1R+BHkutaKGHMtqEEcbaNmFiIAu+HSVND56jV2njm7aYdlyUnJzZD9CBuvXEEvrNGLNbbnfvZc2bBB2VReu8aHb630EbuS7LLkREYz+O+7GO1BfgDb5DhUoI9Q7N9vwshgcE9o5faKbwqD+m+jvIw6GdgsRCz3k0J2mxMJvXcoEZ8FfPhLD8MuxsCSSc7UtCBEQ4RfT02J3tW+D3hVBz+5YOxq3Sljrj5HrPNqdm6l5pyBBVZv6ii2+tRa++e9o+xht3XBKB6JOy1FyMTdELooWPInjNqIBlB6BPImLwMCA64Ay/Rf6xK5+xmWvaQ==
X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;31:e2EPDrsAxseGFkGVl9p+SGrC2/HT8f6pKdZfV44f4sQlYJFZTHhGwARkcgB8lu9JC+FHG9rFzoJOTiJFDU9C90I4eDu4f/dQg9GD3CYb6LPNu1CwjwfgIGp7VIgHmJ4pekNVFljAydP2l1OcnscjKAiNN/sYemk76P/qInyL4ED9GuWryFtBrJSFGRKPXZ+kijzR+sbCUzMF1QreZjXhH9IoA4ZwuYIeP10zmxqFM84VTc2zqe6LCkUjptPPMZbR;20:WgxQ7JbybLGOgPU0p+ILNC6JCKcUPEXjlKY1mmy86ZqcNgAjJG+JXAfENOWHhJ6Z3Tfl45BIRPj32/dmLC5YNZfvhr+6V5U6nHnsFmWZJgeXwOoqEkAYMePczAjchieL/xkGnByfYW1Z8uerz7ZLAp1CEkdjrW1UiOp3+0xBwYeIz8ZDm6b+nxsGQYh4pIkmA6tlaqpzvVGghPiiXNTkDjlxiHdeIRfMUSBKgZfLZnArGJkawPFJYvv6PeKgvgI2K4vehU2/xf7v9FeUrSr7i6Q2JjQ2WfI5miip3OO++pl0+3CUj+pRjilviMz87xUgHKOMaJ25ghxlmNKLYRiu6+dZF15ZdT4W1kZ0dXWGjjydwTXsq/tELDBQhONL8NjpXwffbHy85TDntR7VFRtWAgFqBhqj2awr+s0Pngx1DfpK8oZTRpJLdKeIPEj0+6TlfocLl+2tohYO18EBpOCzgDfM3meu98JE+cbuDD0jge2NPdW9/v7O2jr0GrWdN+tj
X-Microsoft-Antispam-PRVS: <BN6PR15MB1185B462A941636B6C16A32CC09A0@BN6PR15MB1185.namprd15.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(6072148);SRVR:BN6PR15MB1185;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1185;
X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;4:88j/eXSLVawYmIgwfk99Ipis0vP8QfSaBJUwmf+9XOmZ4sVZW4NYT7BEH3ThcSDKU45YuLXfsIRhWWd9Q5iaXk71U4vaqWZ7J/hB7NSm5BPGO/fPfNhcj6F4sC2MM9eF3mWqNgxY3E45shmtB2Q3J3PoSkJ+Ooc4aLMZtME/vmM02wULP5CD4lZ7PzLHT0gFBmlmR2pPntSqEuURd7K5ztmfp7JssCG1YMXf7Cum5BluxwdbFY12HLTc3S1e4WxDBH7LYKuGrjrHrRHKpOufMwbUYVAQjBntrjuzwJRDhlBsfeYvr/YeMK0UnfVMdc6VttOjMlrPUlww8nAOpz+RVrgXjA4xstAIWOpXHC1/sDZ9FSfz5Z1yzJLv+a5r2dj7BCrwB6uurGWwxmzg7vlACe5tKSEKSkmJqB7rzVkikQTBoPnfY5hxkdmr4bv+Dye/RJgwE4RS2r7Dv74nrlfCn5jG1Z9GOfPvk2JGN0lCBPFB1UwOadCjmC0KoXDnx49h2/MKjsNTwNem8Tt+VDM1Sss+TRNwTzArgUVmiKhek0Z0f2Hauqi/TecatxAZjWMYfzixrwXUgBrpP03AfnObrQ==
X-Forefront-PRVS: 01565FED4C
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(39450400003)(39850400002)(39840400002)(39410400002)(189002)(377454003)(199003)(24454002)(31696002)(5660300001)(68736007)(117156001)(54356999)(189998001)(4001350100001)(81166006)(7736002)(50986999)(33646002)(23746002)(76176999)(5001770100001)(97736004)(64126003)(305945005)(66066001)(101416001)(8676002)(65956001)(47776003)(65806001)(4326007)(2906002)(81156014)(6666003)(3846002)(558084003)(2201001)(92566002)(106356001)(36756003)(6116002)(6486002)(105586002)(77096006)(229853002)(86362001)(15650500001)(50466002)(42186005)(90366009)(31686004)(38730400001)(230700001)(83506001)(65826007)(2950100002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1185;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en;
X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1185;23:DoMaVhxJZlIBiVriw+oLmptujXNbpdQKo/3xL?=
 =?Windows-1252?Q?4+SPEJtHTXYOlrWPPTBO3WCIoJuAqy3U7YP7meE+WTLMUmEeTRypS+gy?=
 =?Windows-1252?Q?yGw4AOw9ktWtWHam/ZpCXQflj3Ev7fcI8RM80PDQs81VEAY5gjx/u0xG?=
 =?Windows-1252?Q?F5VBFu+trIiBFsqHzWj64uB5GbIix7UiDyNSbrXHedQki1qKG5zwjYno?=
 =?Windows-1252?Q?zT7d+XsdVxsvvxBs1w/lpdhdbgN/Wk2rUqDItmf4N+byFOPdn9uGJXEl?=
 =?Windows-1252?Q?Kp2t5S5vBo1hpCwWr26NojZCLs/X4dXU2lpDA/v3AYa4JGxL1/c9fg/Y?=
 =?Windows-1252?Q?0O8CZK2+TOYjdgTveK3qGy4oYDP+q/GjkDDczglFzVqCSOKsK9Zq0cdx?=
 =?Windows-1252?Q?w31sLe4kAFSIHMw6UyNAYYQGqzw+8LMZaFF6C5p29ZxbT3UMHkf4Giog?=
 =?Windows-1252?Q?AZ+YzxU4MJQF5onJT6yU8omK5A2tuqBWQYLUs0LaBHDdyr/tuIVk1b5k?=
 =?Windows-1252?Q?Q5eWnDt8Mvkq1DLdvte4tem2BUv1fW14Ooay68mKyoIvLJoFqLx/np4Z?=
 =?Windows-1252?Q?x4rbXI0M4l4z39TPIEYexxQBhraYQuk2ySa+hOLlGJ4EL8e/BsV7M5EB?=
 =?Windows-1252?Q?4wb10Armib6nUOa0K56388FvbyU2HW8Wrsw/MKp5hOMy3LreMmPmay41?=
 =?Windows-1252?Q?XQZyA1q6s9HJXt4zcTRDG8RGGvAtZ45FImklf43luS46ZC0kzqrnKXDL?=
 =?Windows-1252?Q?rw5zxZE0K2J8VMBwV/X/ggq2FRpkOxq2zaM9viSRmtLccQvb+4us6a9b?=
 =?Windows-1252?Q?oQ2VeYo8U6mlPZfBS1IdWPmQ/AtjNAw1ADWO84v88a6YNlKaL0hgpB1Y?=
 =?Windows-1252?Q?i1K6psOtXP1AjYNsfF9rgL0/bz85zFCARN8ZIJmtqUv4qf6CDQmE8LVC?=
 =?Windows-1252?Q?7DFaYC8D+JQsmWxJuoBC5jCVwP42FHg75fyBnobd8TL4aLvaN/CnH1pN?=
 =?Windows-1252?Q?rLuAFio0YsNwBiWgCMnzaCVZMd23znFBhW/xGHwLoi6KItrRSqNz3JFQ?=
 =?Windows-1252?Q?Lb7TCUUilT4e2ZEDx1TGcdWzGMh5lqsmRckdLMEeTPkE0NxfgUFDZf02?=
 =?Windows-1252?Q?isGQCwkWdh9Qh4iLTvHcNdyUr3U8Y+w1W5yyQeQgqp6yNOsF9g+y4Cla?=
 =?Windows-1252?Q?LCKacd7KWeFiOw0wzue3UbaagVUxxsFN6Kipbqvhccuo9tradLRyOXPJ?=
 =?Windows-1252?Q?ZgxvgNDk5IcA62p1ss+2LbY/T0uJwA+S2rI/TnwCA7F1UoygWrZ4Covi?=
 =?Windows-1252?Q?CVizXhSHlal3TuRDOGu1r08YdNJuXWCT5bYsJAKC3J/6CggFKhz5CHOe?=
 =?Windows-1252?Q?OIX9jTqkdLnfwa7il83suF9Ox/Ca63Hyz2714wuC4zG4GYTig0lnh1r4?=
 =?Windows-1252?Q?CRKNYeiqJ2FuYPgVRDZLqzOg0+snE/5iPQD1nUMoh1BL/TR6eRYfVuiJ?=
 =?Windows-1252?Q?0dYJV27VZoqMQvEc4RcrVMRKS5vIoZWx017/rZwVDw0ZBGQLcQSgfQoh?=
 =?Windows-1252?Q?uyNWZvt7WPmXiACnscZkakjCbLtDZqrZuObBAnW4gNtdn0wWfHlj+QHP?=
 =?Windows-1252?B?QT09?=
X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;6:58v1ye5kA2Zq80WrM9GbArvpCVb+v6aoCMKl8UjGf6hyK+XzAzFskJzimWbk8KexipHJAU424/43lVtNgL+JCKRpp127nslG3dlGgW6yPzEKXRawBO7a1oo0wStDdeEdb1w1L57OqvW1OueLiya3fauk69xRveMoi71G/kkH7j5pEGsxpdu5EyV7OyMemfO/1cz9Q4Q9V5qsGQwWYqdKpZbdc2sEk2e2WT4GyR+MweBtTpnJuWz7bC8IhPyVWoRxsrQkS3KyOAG4fa2IQq63uhHK0uQGGGcGH14ME14EGGIuG/TTjF9Z80NnOwdZmUvPEGS8htVVOh7igHvsg+AmMUyLSptmQYmQ3igrC7HOsillG6zqrT+9SWaRD3gafs/OoprSVouKYh4dmRdMhin2fK+Q9tgjDCLFLF6I65TS3bs=;5:B+YjZUVC9exxCfjju1qQtZRJdsR4XByosH0Pr5akemDsYFQRM8IPqcBTPZigh0fVoE0kxVAm9+NU2Sh1/ERkk5Y4ndfdtwYqFpGtcdICSBnxOUTtQDUeNd8uBfHLKQhZqAYw4wepCUs2KoL4qXfoWrpW2LMCKnOJiLw3eyNorKg=;24:h5SCt5qg+q1QUSkJDAkm4UmK2VnaNu+SjL3ngMHnjtkJy0TagYWm4Qgcet3wBHRvChM5wjld5MaV5LkZ0Nr0HT+AxHb0AFmosExqWgJeQc0=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;7:sEXKKzRxwAn+tt97qpLESyBjWf69BNukvJ+Ql2O1HvwB37+No+Cn8YiLxW2mNyC1duzvV9aJAFB98mniDu808iQY8GJXJNTS9EgnlUZRwhw+x7FWst2P+6g3R4f5pHHw+oSA3zvqqjNyScMn888VfZiItUhTbDxDW1hgh5Mq52yjVr2A4BSusshM9DCQylMghQPEyog6F4LuQgEpbMj1khvfGwVLRwtnWIxAijrtBKkEGkHlwKaqC9+D+JUbuWeRw6yrn1vHyjvR43U65bty5wgiuNqINh4DEbubl9/UW8TAZkVHo6WkusPibaKzGTYes3s1Zyxk66HOvTC3yDqZbxcZ2eu490Ah07GgVrFn6k+mpcfwOiXycuUDONe2YW4z0gn9fkQRPwL4r9fD9GGPaR2gtYm1AtDkIvt4gE0++6yEnoBeATpOtIvv0lNP665tsMs1sgEDB9oOZohvogFLrg==;20:TZC9YNyxgRZXNnxDzk+dc6+zjNRQMQfIfdWv+sTfrOxSllQqn3ibNhWt5Pszd3IM6+OxdhX4Wzd/ha2JtZbo9ZyEnCQMJ8CBrU7AUVZgwFY++QdTp/JBHtIOaC1VSs3+g4kaVnkdTDRq6eY70JLpynlWIAzlAz3hZaiUKCJL+A8=
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2016 04:08:23.0140 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1185
X-OriginatorOrg: fb.com
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-14_02:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 286
Lines: 9

On 12/13/2016 08:07 PM, Shaohua Li wrote:
> For sync direct IO, generic_file_direct_write/generic_file_read_iter
> will update file access position. Don't duplicate the update in
> .direct_IO. This cause my raid array can't assemble.

That's not great... Thanks, added.

-- 
Jens Axboe