Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755243AbcLNJAW (ORCPT ); Wed, 14 Dec 2016 04:00:22 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:32794 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755014AbcLNI73 (ORCPT ); Wed, 14 Dec 2016 03:59:29 -0500 MIME-Version: 1.0 In-Reply-To: <1481678303-91161-1-git-send-email-jbires@google.com> References: <20161214005847.GB1141@kroah.com> <1481678303-91161-1-git-send-email-jbires@google.com> From: Geert Uytterhoeven Date: Wed, 14 Dec 2016 09:58:53 +0100 X-Google-Sender-Auth: y7-j9b6TFjrMGotZ-d4XtMpiwj8 Message-ID: Subject: Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on To: Max Cc: Arnd Bergmann , Greg KH , Josh Triplett , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1508 Lines: 43 On Wed, Dec 14, 2016 at 2:18 AM, Max wrote: > Without a bool string present, using "# CONFIG_DEVPORT is not set" in > defconfig files would not actually unset devport. This ensured that > /dev/port was always on, but there are reasons a user may wish to disable > it (smaller kernel, attack surface reduction) if it's not being used. Adding > a message here in order to make this user visible. > > Signed-off-by: Max Bires > --- > drivers/char/Kconfig | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig > index 7ad3127..e8fc493 100644 > > --- a/drivers/char/Kconfig > +++ b/drivers/char/Kconfig > @@ -589,10 +589,13 @@ config TELCLOCK > controlling the behavior of this hardware. > > config DEVPORT > - bool > + bool "/dev/port character device" bool "/dev/port character device" if EXPERT? > depends on !M68K > depends on ISA || PCI > default y > + help > + Say Y here if you want to support the /dev/port device. The > + /dev/port device is similar to /dev/mem, but for I/O ports. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds