From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Max <jbires@google.com>, Greg KH <gregkh@linuxfoundation.org>,
        Josh Triplett <josh@joshtriplett.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on
Date: Wed, 14 Dec 2016 10:11:19 +0100
Message-ID: <9437575.LShmc6ajMp@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CAMuHMdWr2JHwUP-WCCZ85gFCDNG_=w7XzKYzywtumvE4ihgfrg@mail.gmail.com>
References: <20161214005847.GB1141@kroah.com> <1481678303-91161-1-git-send-email-jbires@google.com> <CAMuHMdWr2JHwUP-WCCZ85gFCDNG_=w7XzKYzywtumvE4ihgfrg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 499
Lines: 17

On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote:
> >
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -589,10 +589,13 @@ config TELCLOCK
> >           controlling the behavior of this hardware.
> >
> >  config DEVPORT
> > -       bool
> > +       bool "/dev/port character device"
> 
> bool "/dev/port character device" if EXPERT?

I think the 'default y' is good enough, there are good reasons
even for non-EXPERT configurations to turn this off.

	Arnd