Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755311AbcLNJvN (ORCPT ); Wed, 14 Dec 2016 04:51:13 -0500 Received: from slow1-d.mail.gandi.net ([217.70.178.86]:35422 "EHLO slow1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754968AbcLNJvM (ORCPT ); Wed, 14 Dec 2016 04:51:12 -0500 X-Originating-IP: 50.39.169.170 Date: Wed, 14 Dec 2016 01:46:48 -0800 From: Josh Triplett To: Arnd Bergmann Cc: Geert Uytterhoeven , Max , Greg KH , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Message-ID: <20161214094648.aml4mrwzvrqxytzg@x> References: <20161214005847.GB1141@kroah.com> <1481678303-91161-1-git-send-email-jbires@google.com> <9437575.LShmc6ajMp@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9437575.LShmc6ajMp@wuerfel> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 19 On Wed, Dec 14, 2016 at 10:11:19AM +0100, Arnd Bergmann wrote: > On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote: > > > > > > --- a/drivers/char/Kconfig > > > +++ b/drivers/char/Kconfig > > > @@ -589,10 +589,13 @@ config TELCLOCK > > > controlling the behavior of this hardware. > > > > > > config DEVPORT > > > - bool > > > + bool "/dev/port character device" > > > > bool "/dev/port character device" if EXPERT? > > I think the 'default y' is good enough, there are good reasons > even for non-EXPERT configurations to turn this off. Agreed. /dev/port seems like something the majority of modern systems can safely turn off.