Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755228AbcLNK3w (ORCPT ); Wed, 14 Dec 2016 05:29:52 -0500 Received: from verein.lst.de ([213.95.11.211]:40638 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973AbcLNK3v (ORCPT ); Wed, 14 Dec 2016 05:29:51 -0500 Date: Wed, 14 Dec 2016 11:20:39 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Shaohua Li , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Christoph Hellwig Subject: Re: [PATCH] block_dev: don't update file access position for sync direct IO Message-ID: <20161214102039.GA29959@lst.de> References: <58920289-6947-c079-6d96-779408436aeb@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58920289-6947-c079-6d96-779408436aeb@fb.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 244 Lines: 6 On Tue, Dec 13, 2016 at 09:08:18PM -0700, Jens Axboe wrote: > That's not great... Thanks, added. Ooops, yeah - we're still going through ->direct_IO for block devices. I'll take a stab at removing that, as it's just a pointless indirect call.