Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932298AbcLNKze (ORCPT ); Wed, 14 Dec 2016 05:55:34 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:59508 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753100AbcLNKzd (ORCPT ); Wed, 14 Dec 2016 05:55:33 -0500 Date: Wed, 14 Dec 2016 09:24:15 +0100 From: Peter Zijlstra To: "Eric W. Biederman" Cc: Hari Bathini , ast@fb.com, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, daniel@iogearbox.net, rostedt@goodmis.org, Ananth N Mavinakayanahalli , sargun@sargun.me, Aravinda Prasad , brendan.d.gregg@gmail.com Subject: Re: [PATCH v3 3/3] perf tool: add cgroup identifier entry in perf report Message-ID: <20161214082415.GM3124@twins.programming.kicks-ass.net> References: <148156671980.4651.13017595439842763683.stgit@hbathini.in.ibm.com> <148156680219.4651.12310355352884515738.stgit@hbathini.in.ibm.com> <878trkajlc.fsf@xmission.com> <4c6c4754-6a87-56bc-3351-fef699cc57e1@linux.vnet.ibm.com> <87inqnfvr8.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87inqnfvr8.fsf@xmission.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 307 Lines: 7 On Wed, Dec 14, 2016 at 08:56:43AM +1300, Eric W. Biederman wrote: > > I would just make the identifier a structure containing the > device number and the inode number. It didn't look like perf required > the identifier to be a simple integer. Right, perf doesn't care at all here, its just a transport.