Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755514AbcLNNOD (ORCPT ); Wed, 14 Dec 2016 08:14:03 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33600 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbcLNNOB (ORCPT ); Wed, 14 Dec 2016 08:14:01 -0500 Date: Wed, 14 Dec 2016 22:12:30 +0900 From: Stafford Horne To: Geert Uytterhoeven Cc: "linux-kernel@vger.kernel.org" , Jonas Bonn , openrisc@lists.librecores.org, Wu Fengguang , Guenter Roeck Subject: Re: [OpenRISC] [PATCH] openrisc: Add _text symbol to fix ksym build error Message-ID: <20161214131230.GF2650@lianli.shorne-pla.net> References: <1481720102-20169-1-git-send-email-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2034 Lines: 65 Hi Geert, On Wed, Dec 14, 2016 at 01:58:32PM +0100, Geert Uytterhoeven wrote: > Hi Stafford, > > On Wed, Dec 14, 2016 at 1:55 PM, Stafford Horne wrote: > > The build report reports: > > > > .tmp_kallsyms1.o: In function `kallsyms_relative_base': > >>> (.rodata+0x8a18): undefined reference to `_text' > > > > This is when using 'make alldefconfig'. Adding this _text symbol to mark > > the start of the kernel as in other architecture fixes this. > > > > Signed-off-by: Stafford Horne > > --- > > arch/openrisc/kernel/vmlinux.lds.S | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/openrisc/kernel/vmlinux.lds.S b/arch/openrisc/kernel/vmlinux.lds.S > > index ef31fc2..58eaca0 100644 > > --- a/arch/openrisc/kernel/vmlinux.lds.S > > +++ b/arch/openrisc/kernel/vmlinux.lds.S > > @@ -44,6 +44,8 @@ SECTIONS > > /* Read-only sections, merged into text segment: */ > > . = LOAD_BASE ; > > > > + _text = .; > > + > > /* _s_kernel_ro must be page aligned */ > > . = ALIGN(PAGE_SIZE); > > _s_kernel_ro = .; > > @@ -66,6 +68,7 @@ SECTIONS > > * fixup is definitely necessary > > */ > > > > + _data = .; > > This change is not mentioned in the patch description. > Is it required? Does it fix something different? Good point. I was just adding what I saw as missing in others. Also what I read in include/asm-generic/sections.h. However, when I read a bit closer it mentions its only optional. I will remove, it does not fix anything. -Stafford > > _sdata = .; > > > > /* Page alignment required for RO_DATA_SECTION */ > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds