Subject: Re: [PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO
 scheduler
To: Bart Van Assche <bart.vanassche@sandisk.com>, <axboe@kernel.dk>,
        <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1481228005-9245-1-git-send-email-axboe@fb.com>
 <1481228005-9245-7-git-send-email-axboe@fb.com>
 <d4534a17-7fc3-3c55-37fd-aa2fff326795@sandisk.com>
CC: <paolo.valente@linaro.org>, <osandov@fb.com>
From: Jens Axboe <axboe@fb.com>
Message-ID: <d48260a6-c7f1-d5ed-bc21-80b69ed9d2f6@fb.com>
Date: Wed, 14 Dec 2016 08:02:59 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <d4534a17-7fc3-3c55-37fd-aa2fff326795@sandisk.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2016 15:03:03.5711 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192
X-OriginatorOrg: fb.com
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-14_10:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 585
Lines: 19

On 12/14/2016 01:09 AM, Bart Van Assche wrote:
> On 12/08/2016 09:13 PM, Jens Axboe wrote:
>> +static inline bool dd_rq_is_shadow(struct request *rq)
>> +{
>> +	return rq->rq_flags & RQF_ALLOCED;
>> +}
> 
> Hello Jens,
> 
> Something minor: because req_flags_t has been defined using __bitwise
> (typedef __u32 __bitwise req_flags_t) sparse complains for the above
> function about converting req_flags_t into bool. How about changing the
> body of that function into "return (rq->rq_flags & RQF_ALLOCED) != 0" to
> keep sparse happy?

Sure, I can fold in that change.

-- 
Jens Axboe