Subject: Re: [PATCH 1/1] arm64: Correcting format specifier for printing 64
 bit addresses
To: Christoffer Dall <christoffer.dall@linaro.org>,
        Maninder Singh <maninder1.s@samsung.com>
References: <1480925393-8386-1-git-send-email-maninder1.s@samsung.com>
 <20161206161116.GD4816@cbox>
Cc: catalin.marinas@arm.com, will.deacon@arm.com, marc.zyngier@arm.com,
        rkrcmar@redhat.com, cmetcalf@mellanox.com, panand@redhat.com,
        mark.rutland@arm.com, james.morse@arm.com, akpm@linux-foundation.org,
        sandeepa.s.prabhu@gmail.com, labbott@redhat.com, shijie.huang@arm.com,
        ard.biesheuvel@linaro.org, wangkefeng.wang@huawei.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
        pankaj.m@samsung.com, ajeet.y@samsung.com, cpgs@samsung.com,
        Vaneet Narang <v.narang@samsung.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <65935935-bdd9-c6a6-1a33-2bbaf6ffbbc5@redhat.com>
Date: Wed, 14 Dec 2016 17:35:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20161206161116.GD4816@cbox>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 525
Lines: 17


On 06/12/2016 17:11, Christoffer Dall wrote:
> +		kvm_err("Unsupported guest CP%d access at: %08lx\n",
> +			cp, *vcpu_pc(vcpu));
> +	else
> +		kvm_err("Unsupported guest CP%d access at: %016lx\n",
> +			cp, *vcpu_pc(vcpu));
> 
> It feels a bit much to me to have an if-statement to differentiate the
> number of leading zeros, so if it's important to always have fixed
> widths then I would just use %016lx in both cases.

Really, this is just a debugging message.  Just use "0x%lx" and let's
stop bikeshedding. :)

Paolo