Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755881AbcLNREG (ORCPT ); Wed, 14 Dec 2016 12:04:06 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42085 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753040AbcLNREB (ORCPT ); Wed, 14 Dec 2016 12:04:01 -0500 Subject: Re: [PATCH v3 3/3] perf tool: add cgroup identifier entry in perf report To: "Eric W. Biederman" , Peter Zijlstra References: <148156671980.4651.13017595439842763683.stgit@hbathini.in.ibm.com> <148156680219.4651.12310355352884515738.stgit@hbathini.in.ibm.com> <878trkajlc.fsf@xmission.com> <4c6c4754-6a87-56bc-3351-fef699cc57e1@linux.vnet.ibm.com> <87inqnfvr8.fsf@xmission.com> <20161214082415.GM3124@twins.programming.kicks-ass.net> <87k2b233up.fsf@xmission.com> Cc: ast@fb.com, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, daniel@iogearbox.net, rostedt@goodmis.org, Ananth N Mavinakayanahalli , sargun@sargun.me, Aravinda Prasad , brendan.d.gregg@gmail.com From: Hari Bathini Date: Wed, 14 Dec 2016 22:33:21 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <87k2b233up.fsf@xmission.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16121417-7323-0000-0000-0000008876A6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16121417-7324-0000-0000-000001AA3A34 Message-Id: <77cda378-37e7-918c-05e6-09ac7b3ed5c7@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-14_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1612140270 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 597 Lines: 17 On Wednesday 14 December 2016 09:22 PM, Eric W. Biederman wrote: > Peter Zijlstra writes: > >> On Wed, Dec 14, 2016 at 08:56:43AM +1300, Eric W. Biederman wrote: >>> I would just make the identifier a structure containing the >>> device number and the inode number. It didn't look like perf required >>> the identifier to be a simple integer. >> Right, perf doesn't care at all here, its just a transport. > perf report? In that case I think perf cares enough to know there is > some identifier it is reporting things by. Let me post v4 with this change.. Thanks Hari