Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755307AbcLNROC (ORCPT ); Wed, 14 Dec 2016 12:14:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54350 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933243AbcLNROA (ORCPT ); Wed, 14 Dec 2016 12:14:00 -0500 Subject: Re: [PATCH] IB/mlx4: avoid a -Wmaybe-uninitialize warning To: Arnd Bergmann , Yishai Hadas References: <20161025161632.411899-1-arnd@arndb.de> Cc: "David S. Miller" , Jack Morgenstein , Or Gerlitz , Eran Ben Elisha , Moshe Shemesh , Christophe Jaillet , Moni Shoua , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org From: Doug Ledford Message-ID: <8fd869a2-9e7b-bba7-5cf0-af1d078016b6@redhat.com> Date: Wed, 14 Dec 2016 12:13:43 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161025161632.411899-1-arnd@arndb.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SSHcWMGwuWvVLst1UNIIORW2Xfrc2udHX" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 14 Dec 2016 17:13:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2889 Lines: 71 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SSHcWMGwuWvVLst1UNIIORW2Xfrc2udHX Content-Type: multipart/mixed; boundary="NOme76SgKCRES5Eh7VA70OS1RG2iAVt9k"; protected-headers="v1" From: Doug Ledford To: Arnd Bergmann , Yishai Hadas Cc: "David S. Miller" , Jack Morgenstein , Or Gerlitz , Eran Ben Elisha , Moshe Shemesh , Christophe Jaillet , Moni Shoua , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <8fd869a2-9e7b-bba7-5cf0-af1d078016b6@redhat.com> Subject: Re: [PATCH] IB/mlx4: avoid a -Wmaybe-uninitialize warning References: <20161025161632.411899-1-arnd@arndb.de> In-Reply-To: <20161025161632.411899-1-arnd@arndb.de> --NOme76SgKCRES5Eh7VA70OS1RG2iAVt9k Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/25/2016 12:16 PM, Arnd Bergmann wrote: > There is an old warning about mlx4_SW2HW_EQ_wrapper on x86: >=20 > ethernet/mellanox/mlx4/resource_tracker.c: In function =E2=80=98mlx4_SW= 2HW_EQ_wrapper=E2=80=99: > ethernet/mellanox/mlx4/resource_tracker.c:3071:10: error: =E2=80=98eq=E2= =80=99 may be used uninitialized in this function [-Werror=3Dmaybe-uninit= ialized] >=20 > The problem here is that gcc won't track the state of the variable > across a spin_unlock. Moving the assignment out of the lock is > safe here and avoids the warning. >=20 > Signed-off-by: Arnd Bergmann Thanks, applied. --=20 Doug Ledford GPG Key ID: 0E572FDD --NOme76SgKCRES5Eh7VA70OS1RG2iAVt9k-- --SSHcWMGwuWvVLst1UNIIORW2Xfrc2udHX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJYUX3HAAoJELgmozMOVy/devoQAMKv9d90uOxo+DtGGsMvAlGo uJ7WNVEBd15szUlZTP8tu0JQn1/mPmvheWZhoRhtQUWMwUcBK1BZr4O3ZWNthqM8 8LqT6wXWsqkKwdh2QUJBHxVsxyL7WWCQSmzZMvaydAV8s5irOzjIyYpuv2gOtBgr PS8AZ7+GS9jmKPsoZq+rvWKlDaTngmNZuGgSX32LL1AyEgbfRjH7xlUtPttnBsIe n0FIphWNykmGCbYuXGJQ4qg/1QKAUsIMUz8AhtT56HAF+wdjnqilDPmgEe2yY0aY NwpBtMMV34CDdBejbuDvBj+RmV2pbuehRJphWpvO8qCySPnw2oJQ7kQbk55sRtKE cPd9xD1OIGJX3o7fzRtFebSr1W8QYIypafL58Y767XGvpF0PzUWSoBSZ2zw1m9Ys qVmsdzZFlhWRDc2BldcjjEReCuhqJm3oXgRMPYfbQz3/JqJ1OExqiqPFbdyIs03i QL9rbeEizTH+Pq2+CKmsmkAd0CW6PRlOaDg+HMVM7Eqq73p+OTdGK6Z5Vgj55Gvh BkXW4o9/KKRYjkASHrYUBqgIxKmP1rBlPzRU7daXktuJSkQmUtP+3gVCF4APQRU8 hF7v1TT3VFiK6e2FAEPtLzsG6I0tS4BvR1VYTmGM3tss/safk1f5WO4tBHjs4WcH aETraS0tQdJ/Wq41TaOf =WGaN -----END PGP SIGNATURE----- --SSHcWMGwuWvVLst1UNIIORW2Xfrc2udHX--