Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933635AbcLNRUY (ORCPT ); Wed, 14 Dec 2016 12:20:24 -0500 Received: from out03.mta.xmission.com ([166.70.13.233]:57780 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933087AbcLNRUV (ORCPT ); Wed, 14 Dec 2016 12:20:21 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Peter Zijlstra Cc: Hari Bathini , ast@fb.com, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, daniel@iogearbox.net, rostedt@goodmis.org, Ananth N Mavinakayanahalli , sargun@sargun.me, Aravinda Prasad , brendan.d.gregg@gmail.com References: <148156671980.4651.13017595439842763683.stgit@hbathini.in.ibm.com> <148156680219.4651.12310355352884515738.stgit@hbathini.in.ibm.com> <878trkajlc.fsf@xmission.com> <4c6c4754-6a87-56bc-3351-fef699cc57e1@linux.vnet.ibm.com> <87inqnfvr8.fsf@xmission.com> <20161214082415.GM3124@twins.programming.kicks-ass.net> Date: Thu, 15 Dec 2016 04:52:30 +1300 In-Reply-To: <20161214082415.GM3124@twins.programming.kicks-ass.net> (Peter Zijlstra's message of "Wed, 14 Dec 2016 09:24:15 +0100") Message-ID: <87k2b233up.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1cHBuF-0003dt-PD;;;mid=<87k2b233up.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=101.100.131.98;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18SmNIo//0hqWfSBHJaCftlnH6kJEl3Kv8= X-SA-Exim-Connect-IP: 101.100.131.98 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 BAYES_40 BODY: Bayes spam probability is 20 to 40% * [score: 0.3147] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Peter Zijlstra X-Spam-Relay-Country: X-Spam-Timing: total 5541 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 6 (0.1%), b_tie_ro: 4.8 (0.1%), parse: 1.06 (0.0%), extract_message_metadata: 10 (0.2%), get_uri_detail_list: 0.54 (0.0%), tests_pri_-1000: 4.6 (0.1%), tests_pri_-950: 1.19 (0.0%), tests_pri_-900: 0.99 (0.0%), tests_pri_-400: 19 (0.3%), check_bayes: 17 (0.3%), b_tokenize: 4.8 (0.1%), b_tok_get_all: 6 (0.1%), b_comp_prob: 1.57 (0.0%), b_tok_touch_all: 2.8 (0.0%), b_finish: 0.75 (0.0%), tests_pri_0: 403 (7.3%), check_dkim_signature: 0.46 (0.0%), check_dkim_adsp: 3.0 (0.1%), tests_pri_500: 5093 (91.9%), poll_dns_idle: 5087 (91.8%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v3 3/3] perf tool: add cgroup identifier entry in perf report X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 483 Lines: 14 Peter Zijlstra writes: > On Wed, Dec 14, 2016 at 08:56:43AM +1300, Eric W. Biederman wrote: >> >> I would just make the identifier a structure containing the >> device number and the inode number. It didn't look like perf required >> the identifier to be a simple integer. > > Right, perf doesn't care at all here, its just a transport. perf report? In that case I think perf cares enough to know there is some identifier it is reporting things by. Eric